Skip to content

Conversation

@iMouseWu
Copy link

when xmlConfigBuilder parse xml file error,the stack of the error will not identify which file it is.
I think printing error detail in threadLocal may be more friendly for developers

@iMouseWu
Copy link
Author

@harawata
can we discuss this problem when you have time, Thank you.

@harawata
Copy link
Member

Hi @iMouseWu ,

Thanks for the PR!
Improving error messages is very important indeed.

From what I see, XML mapper file location should be added when the original exception is thrown in the core.
Probably here.

I'll look into it when I have some time.
If you could send another PR to the core, that would be great. :)

@iMouseWu
Copy link
Author

@harawata
Thank you for your comment,I can not agree more.
I have sent another PR to the core and closed this PR
At the end,Happy New Year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants