Skip to content

Conversation

@gdarmont
Copy link
Contributor

Hi all,

This PR adds a MyBatisCursorItemReader that leverage feature proposed by mybatis/mybatis-3#52.

Unlike MyBatisPagingItemReader, it allows a correct fetch of statements with nested resultmaps. Also, it’s much more efficient since it does only one statement execution at the beginning and keeps the same cursor open until the end.

Usage samples can be found in SpringBatchTest unit test.

Best regards,
Guillaume

gdarmont added 2 commits May 28, 2013 15:56
* This class allows a correct retrieval of database items, even if nested resultmaps are used (unlike MyBatisPagingItemReader)
  The associated statement must be ordered.
@emacarron
Copy link
Member

Hi! Thank you very much for the contribution. I have just had a fast look at it and looks quite good. I promise I will have a deep look at it sooner or later :)

@hazendaz
Copy link
Member

@gdarmont I know this has been hanging around for a very long time. Any chance you would be willing to rebase this so we can take a closer look. At best this appears to be additional features only and I would see no real reason not to merge it. As @emacarron liked it back in 2013, I'd say it might make it in if the rebase was done and there are no other outstanding concerns.

Use this for rebasing 'git pull --rebase upstream master'

@hazendaz
Copy link
Member

hazendaz commented Jun 7, 2015

I rebased this and added as a branch for time being. This requires a change to mybatis mybatis/mybatis-3#52 before it can be applied.

@gdarmont gdarmont closed this Jul 11, 2015
@gdarmont
Copy link
Contributor Author

Closing this PR as the feature has been reworked in PR #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve a feature or add a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants