Feature/drop support of php7 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
maxbaldanza
reviewed
Jan 5, 2023
Co-authored-by: Max Baldanza <massimiliano.baldanza@instapro.com>
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
… allow doctrine/annotations v2, allow mybuilder/cronos v4
|
All tests are green now without support of doctrine/annotations v2 |
maxbaldanza
reviewed
Jan 6, 2023
Co-authored-by: Max Baldanza <massimiliano.baldanza@instapro.com>
… allow doctrine/annotations v2, allow mybuilder/cronos v4
|
The inspection completed: **** |
maxbaldanza
approved these changes
Jan 6, 2023
|
I've created an issue to support V2 of |
|
Thanks for creating the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to change the github test workflow. After closer look it never worked before correct to restrict symfony to a specific version. Example: https://github.com/mybuilder/cronos-bundle/actions/runs/3289609900/jobs/5421354389 you see that symfony 3.4 run, and many smyfony 5.4 components are installed.
There is a problem with symfony 4 and doctrine/annotations v2. And as it lost LTS i guess it will not be implemented anymore.
If we want to support symfony 4, i guess we can not use doctrine/annotations v2.
"doctrine/annotations": "^1.14 || ^2.0",
It will work on symfony 4 with 1.14 (1.x) but i can not set this logic in composer.
Because of this, i suggest to drop the support of symfony 4.
Or drop the support of "doctrine/annotations" v2. But this will propably block future doctrine updates for the users.
WDYT?