Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to force kong to sync with config #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dgarlitt
Copy link
Contributor

@dgarlitt dgarlitt commented Dec 6, 2017

This adds the ability to use the --force argument to meet the needs of
the feature requested in: #52

Removes the need for ensure: "removed" in configuration files.

@dgarlitt dgarlitt force-pushed the sync-kong-with-config branch from d90d358 to 632f278 Compare December 6, 2017 04:05
@CyExy
Copy link
Contributor

CyExy commented Dec 6, 2017

Thanks for this, I'll pull it down and have a look.

@dgarlitt dgarlitt force-pushed the sync-kong-with-config branch from 632f278 to a53faf3 Compare December 9, 2017 01:42
@dgarlitt
Copy link
Contributor Author

dgarlitt commented Dec 9, 2017

@CyExy I just pushed an update with the test fixture reduced down to just the necessary fields so it's easier to sift through. I also reorganized the unit tests and clarified their descriptions. Let me know if there are any changes to be made.

@dgarlitt dgarlitt force-pushed the sync-kong-with-config branch 2 times, most recently from 858527a to da6a4e1 Compare December 9, 2017 03:10
This adds the ability to use the --force argument to meet the needs of
the feature requested in: mybuilder#52

Removes the need for `ensure: "removed"` in configuration files.
@dgarlitt dgarlitt force-pushed the sync-kong-with-config branch from da6a4e1 to 42d4bfa Compare December 9, 2017 03:42
@dgarlitt
Copy link
Contributor Author

@CyExy Let me know if there are any issues or concerns with this pull request. I'll be happy to make any modifications.

@CyExy
Copy link
Contributor

CyExy commented Dec 16, 2017

@dgarlitt Sorry for taking so long, we had a project launch that took all my energy, I had a quick look and got some ideas I'll find some time to think more about it in the coming days.

@jameswestnz
Copy link

I haven't tested the code myself, but read through and think it's looking good. Would be keen to hear your ideas, as we may be able to help get them implemented :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants