Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertyTypeMatcher shouldn't be deprecated whilst type-filter doesn't support the same set of filters #61

Closed
Bilge opened this issue Jan 25, 2017 · 2 comments
Closed

PropertyTypeMatcher shouldn't be deprecated whilst type-filter doesn't support the same set of filters #61

Bilge opened this issue Jan 25, 2017 · 2 comments

Comments

@Bilge
Copy link
Contributor

Bilge commented Jan 25, 2017 •
edited
Loading

Problem: KeepFilter is only implemented as a regular filter, so to apply it by type one must use the deprecated PropertyTypeMatcher. Ergo PropertyTypeMatcher should not be deprecated until all the regular filters are implemented as type filters.

That is, it's a bad idea to deprecate something without providing an alternative.
mnapoli added a commit that referenced this issue Jan 26, 2017
@mnapoli
Fix #61 Un-deprecate PropertyTypeMatcher
8588b16
@mnapoli mnapoli mentioned this issue Jan 26, 2017
Merged
@mnapoli
Copy link
Member

mnapoli commented Jan 26, 2017

Thanks, please have a look at #64

@mnapoli
Copy link
Member

mnapoli commented Apr 12, 2017

Seems like I forgot to merge…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bilge @mnapoli