Fix deep copying of ArrayObject in PHP 7.4 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PHP 7.4 the storage of an ArrayObject isn't returned as ReflectionProperty.
dontub
force-pushed
the
fix-copying-array-object-php74
branch
from
dd12c91 to
8dcad4e
Compare
mnapoli
reviewed
Dec 17, 2019
| @@ -385,6 +387,18 @@ public function test_it_uses_the_first_filter_matching_for_copying_object_proper | |||
| $this->assertNull($copy->getAProp()->cloned); | |||
| } | |||
|
|
|||
| public function test_it_can_deep_copy_an_array_object() | |||
There was a problem hiding this comment.
Just to be sure: this test fails on PHP 7.4 if the new ArrayObjectFilter is not registered?
There was a problem hiding this comment.
Yes, without ArrayObjectFilter $foo and $copy['foo'] would be same.
|
LGTM, just waiting on the confirmation. |
theofidry
reviewed
Dec 17, 2019
| @@ -59,6 +61,7 @@ public function __construct($useCloneMethod = false) | |||
| { | |||
| $this->useCloneMethod = $useCloneMethod; | |||
|
|
|||
| $this->addTypeFilter(new ArrayObjectFilter($this), new TypeMatcher(ArrayObject::class)); | |||
There was a problem hiding this comment.
Would it make sense to register it only on PHP 7.4+?
There was a problem hiding this comment.
I don't see any reason for not using it in PHP <7.4, do you?
|
@mnapoli @theofidry Can this be merged, or is there anything left to do? |
|
Thank you @dontub! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 7.4 the storage of an ArrayObject isn't returned as
ReflectionProperty.