-
-
Notifications
You must be signed in to change notification settings - Fork 132
Drop support for unsupported PHP versions #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What do you mean by I see this package as a "base building block", unlike most other packages I maintain I try to keep it as unrestrictive as possible. |
Adding a 👍 for a PHP 7 version. |
Copying my answer from #73 for reference: I don't want to have a v2.0 unless it becomes absolutely necessary, here is an explanation:
That being said we could upgrade to PHP 7.1 in a minor version (Composer will handle things without BC breaks for users). But I do not see actual value in that. Don't get me wrong, I am the first to move every one of my open source package to the highest PHP version as possible, and I code daily with 7.2, I love it. But this package is very limited, very stable and very used. I don't see any gain for now. The amount of code is so small that adding a few typehints here and there doesn't seem that useful to prevent bugs. I want to leave it as stable as possible because it just works. If a PHP feature allows us to do new useful stuff, or if it becomes obvious that typehints (or anything else) lets us catch some bugs that are not caught today, I will consider it. As long as there is no reason, I will let it like this. |
We got a reason to upgrade to PHP 7.2 in #86 (and the work was done by a contributor) 🚀 I'll tag a new (minor) release. |
@mnapoli what about adding return types to other methods? The current changes are already breaking and will require a major version, as |
@mnapoli never mind, I read the PR again and I see that |
There are a number of optimizations that could be made to this package by dropping support for PHP <5.6 and even more by dropping support for PHP <7.0.
The text was updated successfully, but these errors were encountered: