Change "equals()" method to accept anything as a parameter #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacek-foremski
force-pushed
the
equals_accepts_anything
branch
from
b1fff0a to
7f285a3
Compare
|
Perfect thanks! |
shadowhand
reviewed
Apr 23, 2019
| */ | ||
| final public function equals(Enum $enum = null) | ||
| final public function equals($variable = null) |
There was a problem hiding this comment.
Why is the = null default kept? $enum->equals() seems like a pretty strange call to make.
There was a problem hiding this comment.
This would be a BC break.
|
This was actually a BC break. Any classes extending Enum and overriding |
|
@willemstuursma |
|
Thanks, I had a second look. Turned out we have an interface that partially implements the methods in Enum. The problem was there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes "equals()" method accept anything as a parameter. It will return false if an argument is an object of different class or not an object.
One of the two PRs needed to fix #86