Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose requests on JobPool Dispose #53

Merged
merged 10 commits into from
Mar 13, 2024
Merged

Dispose requests on JobPool Dispose #53

merged 10 commits into from
Mar 13, 2024

Conversation

mycroes
Copy link
Owner

@mycroes mycroes commented Mar 12, 2024

Fixes #52

@mycroes mycroes requested a review from gfoidl March 12, 2024 20:27
@mycroes
Copy link
Owner Author

mycroes commented Mar 12, 2024

Please ignore the S7 conversion bits of this PR. It's currently deviating from main because #49 is also not yet merged. I would prefer to merge these two and then perhaps add the generic math / static abstract on top.

@mycroes
Copy link
Owner Author

mycroes commented Mar 12, 2024

I'm releasing this as 0.14.5 BTW.

6.x was generating incorrect version numbers for the hotfixes.
@mycroes
Copy link
Owner Author

mycroes commented Mar 12, 2024

After some struggles this has been released as 0.14.6 instead.

Sally7/Internal/DisposableHelper.cs Show resolved Hide resolved
Sally7/Internal/DisposableHelper.cs Outdated Show resolved Hide resolved
Sally7/RequestExecutor/Signal.cs Show resolved Hide resolved
gfoidl
gfoidl previously approved these changes Mar 13, 2024
@mycroes mycroes dismissed gfoidl’s stale review March 13, 2024 20:55

The merge-base changed after approval.

@mycroes mycroes merged commit a1606da into main Mar 13, 2024
3 checks passed
@mycroes mycroes deleted the hotfix/dispose branch March 13, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck requests when receiveSignal is released after Dispose()
2 participants