add performance enhancements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- Directory.Build.props: Language not supported
- global.json: Language not supported
Comments suppressed due to low confidence (1)
src/MyCSharp.HttpClientHints.AspNetCore/HttpClientHintsMiddlewareConfig.cs:37
- Using 'field' in the setter without an explicitly declared backing field may cause compilation issues. Define a private backing field for the property to ensure proper assignment.
field = value;
src/MyCSharp.HttpClientHints.AspNetCore/HttpClientHintsMiddlewareConfig.cs
Show resolved
Hide resolved
- Enhanced `.editorconfig` with new options for various file types and updated severity levels for dotnet style preferences. - Reorganized `Directory.Build.props` with new property groups and added package references for testing and analysis. - Modified `Program.cs` to utilize `WebApplicationBuilder` and `WebApplication` for improved clarity. - Added properties in `HttpClientHintsMiddlewareConfig.cs` for better configurability of middleware. - Updated `HttpClientHintsRequestMiddleware.cs` with XML documentation comments for improved readability. - Improved string comparison accuracy in `HttpClientHintsRegistrationTests.cs` using `StringComparison.Ordinal`. - Cleaned up project files by removing unnecessary Roslynator analyzer references, streamlining dependencies.
There was a problem hiding this comment.
Copilot reviewed 99 out of 105 changed files in this pull request and generated no comments.
Files not reviewed (6)
- .editorconfig: Language not supported
- Directory.Build.props: Language not supported
- Directory.Packages.props: Language not supported
- MyCSharp.HttpClientHints.sln: Language not supported
- global.json: Language not supported
- samples/HttpClientHints.Samples.AspNetCoreMvc/HttpClientHints.Samples.AspNetCoreMvc.csproj: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.