Makes The model, controller, and the screenshot storage disk configurable through the config #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del, the FeedbackController, and the screenshot_disk by specifying them in the config file
|
Awesome, thanks for keeping this package alive :) I would like to have time to work on a v2 but it's not possible atm for me, so I'll keep watching for PR so that the package can live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is fully backward compatible. And it comes with no breaking changes. It simply makes the library more flexible to support more use cases. For example if we want to customize the model, we can extend the one in the package and add our changes. (Useful in multi tenancy applications where we need to define custom databases...)