Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(travis): push notifications to saltstack-formulas.zulipchat.com #191

Merged
merged 2 commits into from
May 21, 2020

Conversation

myii
Copy link
Owner

@myii myii commented May 20, 2020

@pull-assistant
Copy link

pull-assistant bot commented May 20, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix(ssf): update .yamllint with current situation

     feat(travis): push notifications to saltstack-formulas.zulipchat.com...

Powered by Pull Assistant. Last update 10ef1ca ... a1e50da. Read the comment docs.

* Use `%2F` for the forward slash in the topic name:
  - https://docs.travis-ci.com/user/triggering-builds/
  - https://www.degraeve.com/reference/urlencoding.php
* Use Travis `if` conditional rather than `secret` encrypted enviroment
  variable workaround suggested:
  - Not a secret, just the bot's API key
  - Need to be able to modify parts of the URL in certain situations,
    such as the weekly `master` branch tests
  - References:
    + https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables
    + travis-ci/travis-ci#329
    + travis-ci/travis-ci#1094
    + travis-ci/travis-ci#5063
    + travis-ci/travis-ci#6100
    + mozilla/build-tools@c13a297
@myii myii force-pushed the feat/push-travis-notifications-to-zulip branch from 1100676 to a1e50da Compare May 21, 2020 18:27
myii added a commit to saltstack-formulas/apache-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/apt-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/apt-cacher-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/arvados-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/bind-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/cert-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/chrony-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/collectd-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/consul-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/cron-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/deepsea-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/dhcpd-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/django-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/docker-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/eclipse-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/epel-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/exim-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/fail2ban-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/firewalld-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/golang-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/grafana-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/hostsfile-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/icinga2-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/influxdb-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/iptables-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/iscsi-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/prometheus-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/rabbitmq-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/redis-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/rkhunter-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/salt-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/strongswan-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/stunnel-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/sudoers-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/sysctl-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/syslog-ng-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/sysstat-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/systemd-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/telegraf-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/template-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/timezone-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/tomcat-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/ufw-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/users-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/varnish-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/vault-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/vim-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/vsftpd-formula that referenced this pull request May 21, 2020
myii added a commit to saltstack-formulas/zabbix-formula that referenced this pull request May 21, 2020
@myii myii merged commit fa3a349 into master May 21, 2020
@myii myii deleted the feat/push-travis-notifications-to-zulip branch May 21, 2020 19:17
@myii
Copy link
Owner Author

myii commented May 21, 2020

🎉 This PR is included in version 1.146.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii myii added the released label May 21, 2020
myii added a commit to saltstack-formulas/node-formula that referenced this pull request May 28, 2020
myii added a commit to myii/iscsi-formula that referenced this pull request Jun 2, 2020
EpsilonAlpha pushed a commit to EpsilonAlpha/openvpn-formula that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant