feat(template): review PR 249 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myii
added a commit
to saltstack-formulas/template-formula
that referenced
this pull request
May 10, 2022
|
🎉 This PR is included in version 1.387.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
lkubb
added a commit
to lkubb/salt-template-formula
that referenced
this pull request
Dec 11, 2022
commit fc04282 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Sun Jul 17 19:49:14 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W28) [skip ci] * Automated using myii/ssf-formula#454 commit e7fc7eb Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Thu Jun 30 23:10:19 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W26) [skip ci] * Automated using myii/ssf-formula#453 commit 5e5aa74 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Wed Jun 15 23:07:25 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W24) [skip ci] * Automated using myii/ssf-formula#452 commit 32518b9 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Thu Jun 9 00:06:47 2022 +0100 ci: update `pre-commit` configuration inc. for pre-commit.ci [skip ci] * Automated using myii/ssf-formula#450 commit 2e2aa10 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue Jun 7 23:32:12 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W23) [skip ci] * Automated using myii/ssf-formula#449 commit c090f3d Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon May 30 17:30:14 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W22) [skip ci] * Automated using myii/ssf-formula#447 commit de7e21c Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 17 13:23:03 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W20) [skip ci] * Automated using myii/ssf-formula#444 commit d46507b Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 17 08:52:39 2022 +0100 test(system.rb): add support for `mac_os_x` [skip ci] * Automated using myii/ssf-formula#442 commit 6ea1cc2 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 10 10:13:39 2022 +0100 ci(gitlab-ci): fix test conversion job (reset back to #249) [skip ci] * Reset using myii/ssf-formula#440 commit 9349c83 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 10 10:03:47 2022 +0100 test(_mapdata): add verification file for `ubuntu-22` [skip ci] commit 1703b38 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 10 07:35:02 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W19) [skip ci] * Automated using myii/ssf-formula#439 commit e16130d Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Fri May 6 23:19:59 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W18) [skip ci] * Automated using myii/ssf-formula#437 commit 0d1f0dd Author: semantic-release-bot <semantic-release-bot@martynus.net> Date: Mon Apr 25 18:27:38 2022 +0000 chore(release): 5.0.9 [skip ci] ## [5.0.9](saltstack-formulas/template-formula@v5.0.8...v5.0.9) (2022-04-25) ### Continuous Integration * **gitlab-ci:** use Node `16.x` for `pre-commit` in test conversion job ([a1a46ae](saltstack-formulas/template-formula@a1a46ae)) * **kitchen+gitlab:** update for new pre-salted images [skip ci] ([801be3d](saltstack-formulas/template-formula@801be3d)) ### Tests * **_mapdata:** add verification file for `fedora-35` [skip ci] ([6f02d2c](saltstack-formulas/template-formula@6f02d2c)) * **_mapdata:** add verification file for `fedora-36` [skip ci] ([4a38a29](saltstack-formulas/template-formula@4a38a29)) commit bdf294e Merge: 876385a a1a46ae Author: Imran Iqbal <myii@users.noreply.github.com> Date: Mon Apr 25 19:17:08 2022 +0100 Merge pull request #249 from myii/ci/use-node-16-for-test-conversion-pre-commit ci(gitlab-ci): use Node `16.x` for `pre-commit` in test conversion job commit a1a46ae Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 25 17:49:25 2022 +0100 ci(gitlab-ci): use Node `16.x` for `pre-commit` in test conversion job The `test_conversion` job failed during the weekly testing: * https://gitlab.com/myii/template-formula/-/jobs/2371193438 The `stderr` being: ``` /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node) ``` The following references led to this resolution: * pre-commit/pre-commit#2351 * https://stackoverflow.com/questions/71939099/bitbucket-pipeline-error-installing-pre-commit-ts-lint As mentioned there: > a few days ago node 18.x was released and the prebuilt binaries > require a relatively-recent version of glibc Which obviously isn't available on our current Bionic-based `dind` image, i.e. 'myii/ssf-dind-ruby-bionic:2.7.5-1bbox1'. While debugging this situation locally, noticed that the use of a relative `tmp/...` subdirectory was within the `template-formula` directory itself -- so switched this to using `/tmp/...` instead. commit 876385a Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 25 09:12:54 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W17) [skip ci] * Automated using myii/ssf-formula#433
lkubb
added a commit
to lkubb/salt-template-formula-compose
that referenced
this pull request
Dec 11, 2022
commit fc04282 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Sun Jul 17 19:49:14 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W28) [skip ci] * Automated using myii/ssf-formula#454 commit e7fc7eb Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Thu Jun 30 23:10:19 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W26) [skip ci] * Automated using myii/ssf-formula#453 commit 5e5aa74 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Wed Jun 15 23:07:25 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W24) [skip ci] * Automated using myii/ssf-formula#452 commit 32518b9 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Thu Jun 9 00:06:47 2022 +0100 ci: update `pre-commit` configuration inc. for pre-commit.ci [skip ci] * Automated using myii/ssf-formula#450 commit 2e2aa10 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue Jun 7 23:32:12 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W23) [skip ci] * Automated using myii/ssf-formula#449 commit c090f3d Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon May 30 17:30:14 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W22) [skip ci] * Automated using myii/ssf-formula#447 commit de7e21c Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 17 13:23:03 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W20) [skip ci] * Automated using myii/ssf-formula#444 commit d46507b Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 17 08:52:39 2022 +0100 test(system.rb): add support for `mac_os_x` [skip ci] * Automated using myii/ssf-formula#442 commit 6ea1cc2 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 10 10:13:39 2022 +0100 ci(gitlab-ci): fix test conversion job (reset back to #249) [skip ci] * Reset using myii/ssf-formula#440 commit 9349c83 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 10 10:03:47 2022 +0100 test(_mapdata): add verification file for `ubuntu-22` [skip ci] commit 1703b38 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 10 07:35:02 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W19) [skip ci] * Automated using myii/ssf-formula#439 commit e16130d Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Fri May 6 23:19:59 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W18) [skip ci] * Automated using myii/ssf-formula#437 commit 0d1f0dd Author: semantic-release-bot <semantic-release-bot@martynus.net> Date: Mon Apr 25 18:27:38 2022 +0000 chore(release): 5.0.9 [skip ci] ## [5.0.9](saltstack-formulas/template-formula@v5.0.8...v5.0.9) (2022-04-25) ### Continuous Integration * **gitlab-ci:** use Node `16.x` for `pre-commit` in test conversion job ([a1a46ae](saltstack-formulas/template-formula@a1a46ae)) * **kitchen+gitlab:** update for new pre-salted images [skip ci] ([801be3d](saltstack-formulas/template-formula@801be3d)) ### Tests * **_mapdata:** add verification file for `fedora-35` [skip ci] ([6f02d2c](saltstack-formulas/template-formula@6f02d2c)) * **_mapdata:** add verification file for `fedora-36` [skip ci] ([4a38a29](saltstack-formulas/template-formula@4a38a29)) commit bdf294e Merge: 876385a a1a46ae Author: Imran Iqbal <myii@users.noreply.github.com> Date: Mon Apr 25 19:17:08 2022 +0100 Merge pull request #249 from myii/ci/use-node-16-for-test-conversion-pre-commit ci(gitlab-ci): use Node `16.x` for `pre-commit` in test conversion job commit a1a46ae Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 25 17:49:25 2022 +0100 ci(gitlab-ci): use Node `16.x` for `pre-commit` in test conversion job The `test_conversion` job failed during the weekly testing: * https://gitlab.com/myii/template-formula/-/jobs/2371193438 The `stderr` being: ``` /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node) ``` The following references led to this resolution: * pre-commit/pre-commit#2351 * https://stackoverflow.com/questions/71939099/bitbucket-pipeline-error-installing-pre-commit-ts-lint As mentioned there: > a few days ago node 18.x was released and the prebuilt binaries > require a relatively-recent version of glibc Which obviously isn't available on our current Bionic-based `dind` image, i.e. 'myii/ssf-dind-ruby-bionic:2.7.5-1bbox1'. While debugging this situation locally, noticed that the use of a relative `tmp/...` subdirectory was within the `template-formula` directory itself -- so switched this to using `/tmp/...` instead. commit 876385a Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 25 09:12:54 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W17) [skip ci] * Automated using myii/ssf-formula#433
lkubb
added a commit
to lkubb/salt-tool-template-formula
that referenced
this pull request
Dec 11, 2022
commit fc04282 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Sun Jul 17 19:49:14 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W28) [skip ci] * Automated using myii/ssf-formula#454 commit e7fc7eb Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Thu Jun 30 23:10:19 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W26) [skip ci] * Automated using myii/ssf-formula#453 commit 5e5aa74 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Wed Jun 15 23:07:25 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W24) [skip ci] * Automated using myii/ssf-formula#452 commit 32518b9 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Thu Jun 9 00:06:47 2022 +0100 ci: update `pre-commit` configuration inc. for pre-commit.ci [skip ci] * Automated using myii/ssf-formula#450 commit 2e2aa10 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue Jun 7 23:32:12 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W23) [skip ci] * Automated using myii/ssf-formula#449 commit c090f3d Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon May 30 17:30:14 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W22) [skip ci] * Automated using myii/ssf-formula#447 commit de7e21c Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 17 13:23:03 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W20) [skip ci] * Automated using myii/ssf-formula#444 commit d46507b Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 17 08:52:39 2022 +0100 test(system.rb): add support for `mac_os_x` [skip ci] * Automated using myii/ssf-formula#442 commit 6ea1cc2 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 10 10:13:39 2022 +0100 ci(gitlab-ci): fix test conversion job (reset back to #249) [skip ci] * Reset using myii/ssf-formula#440 commit 9349c83 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 10 10:03:47 2022 +0100 test(_mapdata): add verification file for `ubuntu-22` [skip ci] commit 1703b38 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Tue May 10 07:35:02 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W19) [skip ci] * Automated using myii/ssf-formula#439 commit e16130d Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Fri May 6 23:19:59 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W18) [skip ci] * Automated using myii/ssf-formula#437 commit 0d1f0dd Author: semantic-release-bot <semantic-release-bot@martynus.net> Date: Mon Apr 25 18:27:38 2022 +0000 chore(release): 5.0.9 [skip ci] ## [5.0.9](saltstack-formulas/template-formula@v5.0.8...v5.0.9) (2022-04-25) ### Continuous Integration * **gitlab-ci:** use Node `16.x` for `pre-commit` in test conversion job ([a1a46ae](saltstack-formulas/template-formula@a1a46ae)) * **kitchen+gitlab:** update for new pre-salted images [skip ci] ([801be3d](saltstack-formulas/template-formula@801be3d)) ### Tests * **_mapdata:** add verification file for `fedora-35` [skip ci] ([6f02d2c](saltstack-formulas/template-formula@6f02d2c)) * **_mapdata:** add verification file for `fedora-36` [skip ci] ([4a38a29](saltstack-formulas/template-formula@4a38a29)) commit bdf294e Merge: 876385a a1a46ae Author: Imran Iqbal <myii@users.noreply.github.com> Date: Mon Apr 25 19:17:08 2022 +0100 Merge pull request #249 from myii/ci/use-node-16-for-test-conversion-pre-commit ci(gitlab-ci): use Node `16.x` for `pre-commit` in test conversion job commit a1a46ae Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 25 17:49:25 2022 +0100 ci(gitlab-ci): use Node `16.x` for `pre-commit` in test conversion job The `test_conversion` job failed during the weekly testing: * https://gitlab.com/myii/template-formula/-/jobs/2371193438 The `stderr` being: ``` /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node) ``` The following references led to this resolution: * pre-commit/pre-commit#2351 * https://stackoverflow.com/questions/71939099/bitbucket-pipeline-error-installing-pre-commit-ts-lint As mentioned there: > a few days ago node 18.x was released and the prebuilt binaries > require a relatively-recent version of glibc Which obviously isn't available on our current Bionic-based `dind` image, i.e. 'myii/ssf-dind-ruby-bionic:2.7.5-1bbox1'. While debugging this situation locally, noticed that the use of a relative `tmp/...` subdirectory was within the `template-formula` directory itself -- so switched this to using `/tmp/...` instead. commit 876385a Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 25 09:12:54 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W17) [skip ci] * Automated using myii/ssf-formula#433 commit 6be1e23 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 18 23:39:06 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W16) [skip ci] * Automated using myii/ssf-formula#431 commit 7d256e3 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 11 19:24:48 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W15) [skip ci] * Automated using myii/ssf-formula#428 commit 4a38a29 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 11 18:45:59 2022 +0100 test(_mapdata): add verification file for `fedora-36` [skip ci] commit 2dcea70 Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Mon Apr 4 09:25:23 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W14) [skip ci] * Automated using myii/ssf-formula#427 commit 801be3d Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Sun Apr 3 15:09:49 2022 +0100 ci(kitchen+gitlab): update for new pre-salted images [skip ci] * Automated using myii/ssf-formula#426 commit bbc8e2d Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Fri Apr 1 15:38:39 2022 +0100 chore(gemfile.lock): update to latest gem versions (2022-W13) [skip ci] * Automated using myii/ssf-formula#425 commit 6f02d2c Author: Imran Iqbal <iqbalmy@hotmail.com> Date: Wed Mar 30 09:22:13 2022 +0100 test(_mapdata): add verification file for `fedora-35` [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16.xforpre-commitin test conversion job saltstack-formulas/template-formula#249