README: fix installation instructions #19
Conversation
myitcv
force-pushed
the
fix_installation_instructions
branch
2 times, most recently
from
d4d0c72 to
e9c6e53
Compare
myitcv
force-pushed
the
fix_installation_instructions
branch
3 times, most recently
from
b7af7b4 to
d81fe27
Compare
There was a problem hiding this comment.
This seems a bit awkward to me. If possible, it would be much nicer if people could bootstrap using just go get. How about keeping gobin development changes to their own branch (develop perhaps) so master tip always represents the latest tagged version, and use a vendor dir?
Not what we want to do for any other commands, of course, but gobin is our way of escaping this kind of stuff, so a nice way of bootstrapping with go get would be desirable, I think.
myitcv
force-pushed
the
fix_installation_instructions
branch
8 times, most recently
from
ee633f9 to
8716f2d
Compare
| @@ -18,6 +18,8 @@ github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI= | |||
| github.com/onsi/ginkgo v1.6.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= | |||
| github.com/onsi/gomega v1.4.1/go.mod h1:C1qb7wdrVGGVU+Z6iS04AVkA3Q65CEZX59MT0QO5uiA= | |||
| github.com/rogpeppe/go-internal v1.0.0 h1:o4VLZ5jqHE+HahLT6drNtSGTrrUA3wPBmtpgqtdbClo= | |||
| github.com/rogpeppe/go-internal v1.0.0 h1:o4VLZ5jqHE+HahLT6drNtSGTrrUA3wPBmtpgqtdbClo= | |||
There was a problem hiding this comment.
I'm unclear why these two lines are being added here... because it results in two rows being duplicated.
There was a problem hiding this comment.
yeah, that doesn't seem quite right.
There was a problem hiding this comment.
Raised #21 to investigate at a later date
| ### Installation | ||
|
|
||
| ``` | ||
| $ GO111MODULE=off go get -u github.com/myitcv/gobin |
There was a problem hiding this comment.
Do you actually need the GO111MODULE=off part here?
There was a problem hiding this comment.
Yes, I think we do. Because otherwise, if the user is in the context of a module, it will modify that go.mod which is the whole complaint raised in golang/go#27643. I definitely want to side-step that here.
| @@ -18,6 +18,8 @@ github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI= | |||
| github.com/onsi/ginkgo v1.6.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= | |||
| github.com/onsi/gomega v1.4.1/go.mod h1:C1qb7wdrVGGVU+Z6iS04AVkA3Q65CEZX59MT0QO5uiA= | |||
| github.com/rogpeppe/go-internal v1.0.0 h1:o4VLZ5jqHE+HahLT6drNtSGTrrUA3wPBmtpgqtdbClo= | |||
| github.com/rogpeppe/go-internal v1.0.0 h1:o4VLZ5jqHE+HahLT6drNtSGTrrUA3wPBmtpgqtdbClo= | |||
There was a problem hiding this comment.
yeah, that doesn't seem quite right.
myitcv
force-pushed
the
fix_installation_instructions
branch
from
8716f2d to
a4b7997
Compare
Using GO111MODULE=off go get is a simple, backwards compatible way to bootstrap to using gobin.
myitcv
force-pushed
the
fix_installation_instructions
branch
from
a4b7997 to
5bf7dae
Compare
Using GO111MODULE=off go get is a simple, backwards compatible way to
bootstrap to using gobin.
Use v1.0.0-alpha.2 of gohack for examples.