Skip to content

Commit

Permalink
chore: use less permissive file modes
Browse files Browse the repository at this point in the history
  • Loading branch information
Zebradil committed Aug 2, 2023
1 parent 24aba75 commit e8aaf2b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
16 changes: 8 additions & 8 deletions internal/myks/globe.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func (g *Globe) Init(searchPaths []string, applicationNames []string) error {
dataSchemaFileName := filepath.Join(g.RootDir, g.EnvironmentBaseDir, g.DataSchemaFileName)
if _, err := os.Stat(dataSchemaFileName); err != nil {
log.Warn().Err(err).Msg("Unable to find data schema file, creating one")
if err := os.WriteFile(dataSchemaFileName, dataSchema, 0o644); err != nil {
if err := os.WriteFile(dataSchemaFileName, dataSchema, 0o600); err != nil {
log.Fatal().Err(err).Msg("Unable to create data schema file")
}
}
Expand Down Expand Up @@ -218,10 +218,10 @@ func (g *Globe) dumpConfigAsYaml() (string, error) {
yttData := fmt.Sprintf("#@data/values\n---\n%s", yamlData.String())

configFileName := filepath.Join(g.RootDir, g.ServiceDirName, g.TempDirName, g.MyksDataFileName)
if err := os.MkdirAll(filepath.Dir(configFileName), 0o755); err != nil {
if err := os.MkdirAll(filepath.Dir(configFileName), 0o750); err != nil {
return "", err
}
if err := os.WriteFile(configFileName, []byte(yttData), 0o644); err != nil {
if err := os.WriteFile(configFileName, []byte(yttData), 0o600); err != nil {
return "", err
}

Expand Down Expand Up @@ -249,35 +249,35 @@ func (g *Globe) createBaseFileStructure() error {
if _, err := os.Stat(envDir); err == nil {
return notCleanErr
}
if err := os.MkdirAll(envDir, 0o755); err != nil {
if err := os.MkdirAll(envDir, 0o750); err != nil {
return err
}

if _, err := os.Stat(protoDir); err == nil {
return notCleanErr
}
if err := os.MkdirAll(protoDir, 0o755); err != nil {
if err := os.MkdirAll(protoDir, 0o750); err != nil {
return err
}

if _, err := os.Stat(renderedDir); err == nil {
return notCleanErr
}
if err := os.MkdirAll(renderedDir, 0o755); err != nil {
if err := os.MkdirAll(renderedDir, 0o750); err != nil {
return err
}

if _, err := os.Stat(dataSchemaFile); err == nil {
return notCleanErr
}
if err := os.WriteFile(dataSchemaFile, dataSchema, 0o644); err != nil {
if err := os.WriteFile(dataSchemaFile, dataSchema, 0o600); err != nil {
return err
}

if _, err := os.Stat(envsGitignoreFile); err == nil {
return notCleanErr
}
if err := os.WriteFile(envsGitignoreFile, envsGitignore, 0o644); err != nil {
if err := os.WriteFile(envsGitignoreFile, envsGitignore, 0o600); err != nil {
return err
}

Expand Down
4 changes: 2 additions & 2 deletions internal/myks/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func processItemsInParallel(collection interface{}, fn func(interface{}) error)
}

func copyFileSystemToPath(source fs.FS, sourcePath string, destinationPath string) error {
if err := os.MkdirAll(destinationPath, 0o755); err != nil {
if err := os.MkdirAll(destinationPath, 0o750); err != nil {
return err
}
err := fs.WalkDir(source, sourcePath, func(path string, d fs.DirEntry, err error) error {
Expand Down Expand Up @@ -156,7 +156,7 @@ func copyFileSystemToPath(source fs.FS, sourcePath string, destinationPath strin

if d.IsDir() {
// Create the destination directory
if err := os.MkdirAll(destination, 0o755); err != nil {
if err := os.MkdirAll(destination, 0o750); err != nil {
return err
}
} else {
Expand Down

0 comments on commit e8aaf2b

Please sign in to comment.