Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(global-ytt): log ytt output on error #120

Merged
merged 2 commits into from
Oct 29, 2023
Merged

feat(global-ytt): log ytt output on error #120

merged 2 commits into from
Oct 29, 2023

Conversation

kbudde
Copy link
Member

@kbudde kbudde commented Oct 28, 2023

I want to see the message, please use "#! for comments" directly :)

Copy link
Member

@Zebradil Zebradil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to refactor logging, otherwise, it is hard to keep its usage unified. Ideally, I always want to see a stderr of failed commands.

@Zebradil Zebradil enabled auto-merge (squash) October 29, 2023 21:31
@Zebradil Zebradil merged commit a22f7aa into dev Oct 29, 2023
@Zebradil Zebradil deleted the ytt-error branch October 29, 2023 21:33
mykso-bot added a commit that referenced this pull request Oct 31, 2023
# [2.1.0](v2.0.4...v2.1.0) (2023-10-31)

### Bug Fixes

* **init:** ignore top level .myks folder ([#116](#116)) ([b39eb8d](b39eb8d))
* **render:** fix panic if metadata.name is not set ([#123](#123)) ([cdf3266](cdf3266))
* **smart-mode:** correct detection of changes in "_env/argocd" ([#111](#111)) ([ec5dd1d](ec5dd1d))
* **smart-mode:** filter out deleted envs and apps ([93fa2e3](93fa2e3)), closes [#114](#114)

### Features

* add metadata to ytt steps ([#119](#119)) ([6443a20](6443a20))
* **global-ytt:** log ytt output on error ([#120](#120)) ([a22f7aa](a22f7aa))
* **ui:** add smart-mode.only-print flag for debugging ([0a6349a](0a6349a))
Zebradil pushed a commit that referenced this pull request Nov 21, 2023
# [2.1.0](v2.0.4...v2.1.0) (2023-10-31)

### Bug Fixes

* **init:** ignore top level .myks folder ([#116](#116)) ([b39eb8d](b39eb8d))
* **render:** fix panic if metadata.name is not set ([#123](#123)) ([cdf3266](cdf3266))
* **smart-mode:** correct detection of changes in "_env/argocd" ([#111](#111)) ([ec5dd1d](ec5dd1d))
* **smart-mode:** filter out deleted envs and apps ([93fa2e3](93fa2e3)), closes [#114](#114)

### Features

* add metadata to ytt steps ([#119](#119)) ([6443a20](6443a20))
* **global-ytt:** log ytt output on error ([#120](#120)) ([a22f7aa](a22f7aa))
* **ui:** add smart-mode.only-print flag for debugging ([0a6349a](0a6349a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants