fix: sync on integration tests #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #177 +/- ##
=======================================
Coverage 48.16% 48.16%
=======================================
Files 26 26
Lines 2448 2448
=======================================
Hits 1179 1179
Misses 1085 1085
Partials 184 184 ☔ View full report in Codecov by Sentry. |
fritzduchardt
changed the title
fritzduchardt
requested review from
kbudde and
Zebradil
and removed request for
kbudde
|
Does it make sense to update https://github.com/mykso/myks/blob/dev/internal%2Fmyks%2Fassets%2Fgitignore to ignore vendor as well in new repos? |
|
@kbudde maybe, but then all dependencies will be always synced in CI. Users can always gitignore |
Zebradil
approved these changes
Dec 25, 2023
mykso-bot
added a commit
that referenced
this pull request
Dec 25, 2023
mykso-bot
added a commit
that referenced
this pull request
Dec 25, 2023
## [3.0.3](v3.0.2...v3.0.3) (2023-12-25) ### Bug Fixes * **deps:** update module github.com/alecthomas/chroma to v2 ([#184](#184)) ([6e6eede](6e6eede)) * sync on integration tests ([#177](#177)) ([5d2e636](5d2e636)) * **sync:** create vendor directory if not exists ([#159](#159)) ([fd8e878](fd8e878))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the vendor folder from git to ensure that they are created properly by the sync logic and fixed the test to only fail on changes to the rendered directory structure
/Closes #176