Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make behavior on rendering ALL applications consistent and correct do… #79

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: Make behavior on rendering ALL applications consistent and correct do… #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ It supports prototype applications that can be shared between environments and i
Myks supports two positional arguments:

- A comma-separated list of environments to render. If you provide "ALL", all environments will be rendered.
- A comma-separated list of applications to render. If you provide "ALL", all applications will be rendered.
- A comma-separated list of applications to render. If you don't provide this argument or provide "ALL", all applications will be rendered.

If you do not provide any positional arguments, myks will run in "Smart Mode". In Smart Mode, myks will only render environments and applications that have changed since the last run.
`,
Expand Down Expand Up @@ -75,7 +75,9 @@ If you do not provide any positional arguments, myks will run in "Smart Mode". I
if onlyArgs[0] != "ALL" {
targetEnvironments = strings.Split(onlyArgs[0], ",")
}
targetApplications = strings.Split(onlyArgs[1], ",")
if onlyArgs[1] != "ALL" {
targetApplications = strings.Split(onlyArgs[1], ",")
}
default:
err := errors.New("Too many positional arguments")
log.Error().Err(err).Msg("Unable to parse positional arguments")
Expand Down