feat: remove t,r,b,l shortcut props

this props are not standard in styled-system. Also, it is too short to be overwritten or make a confusion.
mym0404 · Mar 19, 2024 · 5cc1413 · 5cc1413
1 parent 89d8eab
commit 5cc1413
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 28 deletions.
diff --git a/doc/docs/usage/sx-props.mdx b/doc/docs/usage/sx-props.mdx
@@ -50,14 +50,10 @@ px: Token<'space'>; // paddingX
 paddingY: Token<'space'>; 
 py: Token<'space'>; // paddingY 
 top: Token<'space'>; 
-t: Token<'space'>; // top 
-right: Token<'space'>; 
-r: Token<'space'>; // right 
-bottom: Token<'space'>; 
-b: Token<'space'>; // bottom 
-left: Token<'space'>; 
-l: Token<'space'>; // left 
-gap: Token<'space'>; // only works if parsed result is number 
+right: Token<'space'>;
+bottom: Token<'space'>;
+left: Token<'space'>;
+gap: Token<'space'>; // only works if parsed result is number
 gapX: Token<'space'>; // only works if parsed result is number 
 gapY: Token<'space'>; // only works if parsed result is number
 ```

diff --git a/src/@types/SxProps.ts b/src/@types/SxProps.ts
@@ -40,13 +40,9 @@ export const _allPropList = [
  'paddingY',
  'py',
  'top',
- 't',
  'right',
- 'r',
  'bottom',
- 'b',
  'left',
- 'l',
  'gap',
  'gapX',
  'gapY',
@@ -131,13 +127,9 @@ type ThemedSpaceTokenProps = {
  paddingY: Token<'space'>;
  py: Token<'space'>; // paddingY
  top: Token<'space'>;
- t: Token<'space'>; // top
  right: Token<'space'>;
- r: Token<'space'>; // right
  bottom: Token<'space'>;
- b: Token<'space'>; // bottom
  left: Token<'space'>;
- l: Token<'space'>; // left
  gap: Token<'space'>; // only works if parsed result is number
  gapX: Token<'space'>; // only works if parsed result is number
  gapY: Token<'space'>; // only works if parsed result is number

diff --git a/src/util/propsToThemedStyle.ts b/src/util/propsToThemedStyle.ts
@@ -215,26 +215,18 @@ export const propsToThemedStyle = ({
  fillViewStyleIfNotNullish(ret, 'paddingVertical', parseSpace(sx.paddingY ?? sx.py));
  fillViewStyleIfNotNullish(ret, 'paddingHorizontal', parseSpace(sx.paddingX ?? sx.px));
 
- fillViewStyleIfNotNullish(
- ret,
- 'top',
- parseSpace(sx.top ?? sx.t ?? (sx.absoluteFill ? 0 : undefined)),
- );
+ fillViewStyleIfNotNullish(ret, 'top', parseSpace(sx.top ?? (sx.absoluteFill ? 0 : undefined)));
  fillViewStyleIfNotNullish(
  ret,
  'right',
- parseSpace(sx.right ?? sx.r ?? (sx.absoluteFill ? 0 : undefined)),
+ parseSpace(sx.right ?? (sx.absoluteFill ? 0 : undefined)),
  );
  fillViewStyleIfNotNullish(
  ret,
  'bottom',
- parseSpace(sx.bottom ?? sx.b ?? (sx.absoluteFill ? 0 : undefined)),
- );
- fillViewStyleIfNotNullish(
- ret,
- 'left',
- parseSpace(sx.left ?? sx.l ?? (sx.absoluteFill ? 0 : undefined)),
+ parseSpace(sx.bottom ?? (sx.absoluteFill ? 0 : undefined)),
  );
+ fillViewStyleIfNotNullish(ret, 'left', parseSpace(sx.left ?? (sx.absoluteFill ? 0 : undefined)));
 
  // endregion