Bump to @actions/cache v4 to fix caching failures#48
Bump to @actions/cache v4 to fix caching failures#48agriyakhetarpal wants to merge 8 commits intomymindstorm:masterfrom
@actions/cache v4 to fix caching failures#48Conversation
agriyakhetarpal
left a comment
There was a problem hiding this comment.
The tests ran in a PR on my fork (agriyakhetarpal#1), and have passed as well: https://github.com/agriyakhetarpal/setup-emsdk/actions/runs/15252190352/job/42891431540?pr=1, where I had temporarily changed the workflows to adjust this. I've put some suggestions below in my self-review to undo them:
| uses: agriyakhetarpal/setup-emsdk@update-to-cache-v4 | ||
| with: | ||
| version: 2.0.20 | ||
| version: 4.0.9 |
There was a problem hiding this comment.
2.0.20 is a bit too old by now, would it be okay to have bumped to 4.0.9?
|
Hi @mymindstorm, would you be able to review this PR in the near future? Currently, setting up Emscripten takes three minutes on all workflow runs due to the obsolete I will be creating a friendly fork under the @pyodide organisation in the meantime to use this action to speed up builds. I shall archive it as soon as you return to active development on this repository, I promise! :) |
|
Hi @mymindstorm and to those subscribed to this PR: I created a friendly fork at https://github.com/pyodide/setup-emsdk/ and a corresponding release at https://github.com/pyodide/setup-emsdk/releases/tag/v15 for our use, which directs to this repository for accreditation. It will be archived once this PR is merged and included in a release. It can be used by swapping out the actions from - uses: mymindstorm/setup-emsdk@v14to - uses: pyodide/setup-emsdk@v15 |
|
@agriyakhetarpal confirming the fork worked, thanks for publishing! |
|
@mymindstorm, hello! Can you view this request? |
Co-Authored-By: Danil Ovchinnikov <danil42worker@gmail.com>
Co-Authored-By: Danil Ovchinnikov <danil42worker@gmail.com>
|
Thanks @Danil42Russia, good catch! |
This shall fix #47. The linked issue has more details; the gist is that actions/cache v3 is deprecated and GitHub has advised users and Actions authors to move to v4 to fix builds.