Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to stderr of emsdk construct_env #7

Merged
merged 2 commits into from
Jul 12, 2020

Conversation

kichikuou
Copy link
Contributor

emscripten-core/emsdk#544 changed emsdk construct_env to print messages to stderr.

emscripten-core/emsdk#544 changed `emsdk construct_env` to print
messages to stderr.
@mymindstorm
Copy link
Owner

Thanks for the PR! This will mess up windows and the CI is failing. Could you listen to both stderr and stdout?

@kichikuou
Copy link
Contributor Author

Changed to listen to both stderr and stdout, but the CI is still failing. 😕
(Does run.yml actually run against PR? It uses mymindstorm/setup-emsdk@master.)

@mymindstorm
Copy link
Owner

Oops, that explains it!

@mymindstorm mymindstorm merged commit 176527d into mymindstorm:master Jul 12, 2020
@kichikuou kichikuou deleted the env-fix branch July 12, 2020 08:15
lopopolo added a commit to artichoke/playground that referenced this pull request Jul 21, 2020
Upstream emsdk changed the setup scripts, which breaks v4 of the setup-emsdk action.

See mymindstorm/setup-emsdk#7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants