Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a dynamic version for com.amazonaws:aws-java-sdk-s3 #20

Closed
erdi opened this issue Apr 25, 2019 · 3 comments · Fixed by #31
Closed

Don't use a dynamic version for com.amazonaws:aws-java-sdk-s3 #20

erdi opened this issue Apr 25, 2019 · 3 comments · Fixed by #31

Comments

@erdi
Copy link
Contributor

erdi commented Apr 25, 2019

Dynamic versions published in the pom cause unnecessary trips to maven repo to check if new version is available for consumers and can lead to non-reproducible builds

@nhoughto
Copy link

Simplest workaround for this is to use the older style gradle plugin declaration with a resolution strategy

buildscript {
    repositories {
        maven {
            url "https://plugins.gradle.org/m2/"
        }
    }
    dependencies {
        classpath "gradle.plugin.ch.myniva.gradle:s3-build-cache:0.9.0"
    }
    //This is to solve for https://github.com/myniva/gradle-s3-build-cache/issues/20
    configurations.classpath {
        resolutionStrategy {
            force 'com.amazonaws:aws-java-sdk-s3:1.11.582'
        }
    }
}
apply plugin: ch.myniva.gradle.caching.s3.AwsS3Plugin

@bsideup
Copy link

bsideup commented Oct 6, 2019

FYI this one have caused us a major CI breakage because new SDK's version is unavailable for some reason.

We did lock the version (as was suggested by @nhoughto, thanks!), but this sounds rather a problem with the plugin, so please, consider fixing it ASAP (especially given the unavailability of the SDK's version that I expect to affect every other project too)

@mkrup
Copy link

mkrup commented Mar 23, 2020

@myniva, Hi!
Thanks for the great plugin.
I have a case when one build fills cache and then other builds read data from it.
When new version of amazon sdk is being published in the middle of the pipeline then it changes all cache keys and depndednt builds take nothing from cache.
Do you have plans to fix the issue?

mkrup added a commit to mkrup/gradle-s3-build-cache that referenced this issue Mar 23, 2020
myniva pushed a commit that referenced this issue Mar 26, 2020
myniva added a commit that referenced this issue Mar 26, 2020
Pin dependencies to fixed versions.

fixes #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants