-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS session token to credentials #16
Add AWS session token to credentials #16
Conversation
f0fc16b
to
30ad1db
Compare
Hi @durbon , I'm glad you like the plugin and very happy to have you as another contributor. As far as I can tell for now, your changes make sense to me. I would kindly ask you to revert the formatting of the classes to the style they were before. Makes it a lot easier for me to do the review :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the format changes.
…S credentials add new clausure to use the BasicSessionCredentials when it is present
30ad1db
to
c794bd9
Compare
@myniva Thanks for considering to add the PR into the project Any doubts, please let me know Regards |
Thanks for updating the files. One last request: Please bump the |
@myniva Done! Thanks! |
Congratulation for the project! Super useful for us using S3 like Remote Build Cache.
We have done a little change in order to use the AWS credentials as we are using AWS STS credentials which require the session token.
The PR just add a new check to previous
BasicAWSCredentials
using instead ofBasicSessionCredentials