myniva/gradle-s3-build-cache#5: Adds option to use reduced redundancy… #6
Conversation
…as the default. Adds tests for same. Removes failing test 'AwsS3BuildCacheServiceFactoryTest.testIllegalConfigWithInvalidRegion'.
README.md
Outdated
| @@ -46,6 +46,7 @@ The AWS S3 build cache implementation requires two configuration options: | |||
| | ----------------- | ----------- | | |||
| | region | The AWS region the S3 bucket is located in. | | |||
| | bucket | The name of the AWS S3 bucket where cache objects should be stored. | | |||
| | reducedRedundancy | Whether or not to use [reduced redundancy](https://aws.amazon.com/s3/reduced-redundancy/). Enabled by default. | | |||
There was a problem hiding this comment.
The AWS S3 build cache implementation requires two configuration options (line 43)
This is no longer valid. What do you think about adding a new column "Default Value" and mentioning that all parameters which do not have a default are mandatory?
| import static org.mockito.Mockito.*; | ||
|
|
||
| public class AwsS3BuildCacheServiceTest { | ||
| @Mock |
There was a problem hiding this comment.
Please use 2 spaces for indentation like in the other classes.
| import org.junit.Test; | ||
| import org.mockito.Mock; | ||
| import org.mockito.MockitoAnnotations; | ||
|
|
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
|
|
||
| import static org.mockito.ArgumentMatchers.any; |
There was a problem hiding this comment.
Please move before non static imports.
| @@ -0,0 +1,73 @@ | |||
| package ch.myniva.gradle.caching.s3.internal; | |||
There was a problem hiding this comment.
Please add missing license header:
/*
* Copyright 2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
antillean
force-pushed
the
reduced_redundancy
branch
from
56725bd to
ba11c43
Compare
|
Sorry for being so late in making these changes! I must've missed the email notifications, and then forgot about this. >_> Let me know if you'd like me to make other changes. Also, it's worth mentioning: I've been using your current version (0.3.0) of this plugin -- so a version without this change -- and all the cache artefacts uploaded to the s3 bucket use the Reduced Redundancy storage class and I have no idea why. :/ |
Adds option to use reduced redundancy storage, and sets it as the default. Adds tests for same. Removes failing test 'AwsS3BuildCacheServiceFactoryTest.testIllegalConfigWithInvalidRegion'.