Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config driven install #393

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

vyadh
Copy link
Contributor

@vyadh vyadh commented Sep 9, 2024

This PR does a few things, mostly in pursuit of #380:

  1. Installs all tools required by the runner itself (at least, as far as I can determine)
  2. Installs all optional tools driven from a config file
    a) apt installs are just a concatenated package list
    b) script-based tools it takes the function name to install each tool from the config
  3. Takes the uid and gid from a config file, which helps matching the runner user against host user configuration (since we have a build config file now anyway...)

I took the opportunity to split out docker-cli from docker-ce. The main reason being that if you're delegating docker builds to the host runner, you only need the cli. One extra apt install but I doubt this has much impact on the build time.

Copy link
Owner

@myoung34 myoung34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes to README.md
I've captured them in a doc to put on the wiki instead of the README

@myoung34 myoung34 merged commit a55d4f9 into myoung34:master Sep 26, 2024
11 checks passed
@myoung34
Copy link
Owner

Cool work, thanks! I'll update the wiki

@vyadh
Copy link
Contributor Author

vyadh commented Sep 26, 2024

Thanks for merging! This is going to be super useful to keep in sync with updates but retain a minimal image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants