Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): add useToggleInputContext composable #223

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

EdieLemoine
Copy link
Member

No description provided.

EdieLemoine added a commit to myparcelnl/prestashop that referenced this pull request Oct 10, 2024
- Fixes "disable delivery options" in product settings not being saved

Needs myparcelnl/js-pdk#223
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 53.52113% with 33 lines in your changes missing coverage. Please review.

Project coverage is 66.59%. Comparing base (ef94d82) to head (1c3aeb6).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pps/admin/src/composables/useToggleInputContext.ts 44.44% 20 Missing ⚠️
apps/admin-component-tests/src/TestSuite.ts 0.00% 4 Missing ⚠️
...eset-default/src/components/DefaultToggleInput.vue 82.35% 0 Missing and 3 partials ⚠️
...s/admin/src/composables/useTriStateInputContext.ts 25.00% 3 Missing ⚠️
apps/admin/src/utils/booleanToTriState.ts 60.00% 0 Missing and 2 partials ⚠️
...mponent-tests/src/components/runToggleInputTest.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   66.63%   66.59%   -0.04%     
==========================================
  Files         692      693       +1     
  Lines       19131    19172      +41     
  Branches      730      729       -1     
==========================================
+ Hits        12747    12768      +21     
- Misses       5664     5685      +21     
+ Partials      720      719       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EdieLemoine added a commit to myparcelnl/prestashop that referenced this pull request Oct 10, 2024
- Fixes "disable delivery options" in product settings not being saved

Needs myparcelnl/js-pdk#223
@myparcel-bot myparcel-bot bot added the approved (Auto) label Oct 11, 2024
@EdieLemoine EdieLemoine added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit c0e1f59 Oct 16, 2024
10 of 12 checks passed
@EdieLemoine EdieLemoine deleted the feat/add-toggle-input-composable branch October 16, 2024 10:42
EdieLemoine added a commit to myparcelnl/prestashop that referenced this pull request Oct 24, 2024
- Fixes "disable delivery options" in product settings not being saved

Needs myparcelnl/js-pdk#223
myparcel-bot bot pushed a commit to myparcelnl/prestashop that referenced this pull request Oct 24, 2024
- Fixes "disable delivery options" in product settings not being saved

Needs myparcelnl/js-pdk#223
myparcel-bot bot pushed a commit to myparcelnl/prestashop that referenced this pull request Oct 24, 2024
- Fixes "disable delivery options" in product settings not being saved

Needs myparcelnl/js-pdk#223
myparcel-bot bot pushed a commit to myparcelnl/prestashop that referenced this pull request Oct 30, 2024
- Fixes "disable delivery options" in product settings not being saved

Needs myparcelnl/js-pdk#223
myparcel-bot bot pushed a commit to myparcelnl/prestashop that referenced this pull request Oct 30, 2024
- Fixes "disable delivery options" in product settings not being saved

Needs myparcelnl/js-pdk#223
myparcel-bot bot pushed a commit to myparcelnl/prestashop that referenced this pull request Oct 30, 2024
- Fixes "disable delivery options" in product settings not being saved

Needs myparcelnl/js-pdk#223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

3 participants