Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ordermode): show shipment label when printed from backoffice #227

Merged

Conversation

joerivanveen
Copy link
Contributor

INT-627

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.62%. Comparing base (98f30e8) to head (9ed1c0d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...omponents/OrderListItem/OrderModeOrderListItem.vue 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   52.66%   52.62%   -0.05%     
==========================================
  Files         728      728              
  Lines       10238    10246       +8     
  Branches      786      786              
==========================================
  Hits         5392     5392              
- Misses       4070     4078       +8     
  Partials      776      776              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FreekVR
Copy link

FreekVR commented Dec 11, 2024

Looks good, but please verify the commit message also covers the changes to this repository. It might already, if ShipmentLabel is the barcode (perhaps reword barcode to shipment label in the commit message though in that case)

@myparcel-bot myparcel-bot bot added the approved (Auto) label Dec 11, 2024
@joerivanveen joerivanveen changed the title fix(ordermode): show barcode when printed from backoffice fix(ordermode): show shipment label when printed from backoffice Dec 11, 2024
@CherMyParcel CherMyParcel added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 32b3368 Dec 16, 2024
11 of 12 checks passed
@CherMyParcel CherMyParcel deleted the fix/ordermode/show-barcode-when-printed-from-backoffice branch December 16, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

4 participants