Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add receipt code to admin #228

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GravendeelJochem
Copy link

INT-702

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.59%. Comparing base (486d8aa) to head (5b761b9).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/shipmentOptions/fields/createReceiptCodeField.ts 16.66% 10 Missing ⚠️
...forms/shipmentOptions/createShipmentOptionsForm.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   52.62%   52.59%   -0.03%     
==========================================
  Files         728      729       +1     
  Lines       10246    10263      +17     
  Branches      786      786              
==========================================
+ Hits         5392     5398       +6     
- Misses       4078     4089      +11     
  Partials      776      776              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the feat-add-receipt-code branch 2 times, most recently from 8bda58d to 6fa3603 Compare December 16, 2024 12:11
Copy link
Contributor

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moet de createReceiptCodeField.ts niet in een test verankerd worden?

@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Dec 17, 2024
@myparcel-bot myparcel-bot bot force-pushed the feat-add-receipt-code branch from 6fa3603 to 5b761b9 Compare December 17, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants