Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete subscription endpoint #167

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Cysword
Copy link
Contributor

@Cysword Cysword commented Apr 10, 2024

No description provided.

Copy link

@mknijnenberg mknijnenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misschien wel even de types hier aanpassen om de globals goed te definiëren?

@myparcel-bot myparcel-bot bot force-pushed the feat/add-delete-subscription-endpoint branch from 8f0f07f to d8da825 Compare April 16, 2024 14:56
@myparcel-bot myparcel-bot bot force-pushed the feat/add-delete-subscription-endpoint branch from d8da825 to d6226b4 Compare April 16, 2024 14:58
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.84%. Comparing base (fcc8584) to head (d6226b4).

Files Patch % Lines
...points/private/subscriptions/DeleteSubscription.ts 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   92.83%   92.84%   +0.01%     
==========================================
  Files          93       94       +1     
  Lines        2191     2209      +18     
  Branches      123      124       +1     
==========================================
+ Hits         2034     2051      +17     
  Misses         34       34              
- Partials      123      124       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdieLemoine EdieLemoine changed the title feat: add DeleteSubscription endpoint feat: add delete subscription endpoint Apr 16, 2024
@myparcel-bot myparcel-bot bot added the approved (Auto) label Apr 16, 2024
@EdieLemoine EdieLemoine added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 4d435b3 Apr 16, 2024
9 checks passed
@EdieLemoine EdieLemoine deleted the feat/add-delete-subscription-endpoint branch April 16, 2024 15:11
myparcel-bot bot added a commit that referenced this pull request Apr 16, 2024
## [3.9.0](v3.8.1...v3.9.0) (2024-04-16)

### ✨ New Features

* add delete subscription endpoint ([#167](#167)) ([4d435b3](4d435b3))
* add duplicate shop endpoint ([#161](#161)) ([5c80d3f](5c80d3f))
* add types for carrier options parameters ([#165](#165)) ([33e5624](33e5624))
* update account type ([#166](#166)) ([0ca1da3](0ca1da3))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Apr 16, 2024

🎉 This PR is included in version 3.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants