Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types for carrier options parameters #165

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

Cysword
Copy link
Contributor

@Cysword Cysword commented Apr 8, 2024

Path was not typed correctly
add parameter types

@myparcel-bot myparcel-bot bot force-pushed the feat/add-type-for-carrier-options-parameters branch from a893887 to 5e60c48 Compare April 16, 2024 14:56
@myparcel-bot myparcel-bot bot force-pushed the feat/add-type-for-carrier-options-parameters branch from 5e60c48 to c2ca408 Compare April 16, 2024 14:58
Copy link
Member

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je moet alleen nog ff die interface veranderen naar type

@myparcel-bot myparcel-bot bot added the approved (Auto) label Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (fcc8584) to head (cf3d494).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   92.83%   92.86%   +0.02%     
==========================================
  Files          93       93              
  Lines        2191     2200       +9     
  Branches      123      123              
==========================================
+ Hits         2034     2043       +9     
  Misses         34       34              
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdieLemoine EdieLemoine added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 33e5624 Apr 16, 2024
5 checks passed
@EdieLemoine EdieLemoine deleted the feat/add-type-for-carrier-options-parameters branch April 16, 2024 15:11
myparcel-bot bot added a commit that referenced this pull request Apr 16, 2024
## [3.9.0](v3.8.1...v3.9.0) (2024-04-16)

### ✨ New Features

* add delete subscription endpoint ([#167](#167)) ([4d435b3](4d435b3))
* add duplicate shop endpoint ([#161](#161)) ([5c80d3f](5c80d3f))
* add types for carrier options parameters ([#165](#165)) ([33e5624](33e5624))
* update account type ([#166](#166)) ([0ca1da3](0ca1da3))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Apr 16, 2024

🎉 This PR is included in version 3.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants