fix: delivery options per carrier #595
Conversation
| @@ -571,6 +571,30 @@ public function upgrade(ModuleDataSetupInterface $setup, ModuleContextInterface | |||
| } | |||
| } | |||
|
|
|||
| if (version_compare($context->getVersion(), '4.2.0', '<')) { | |||
There was a problem hiding this comment.
Kan dit monster ook in een losse functie?
There was a problem hiding this comment.
Dit upgrade bestand heeft het overal op deze manier gestructureerd, weet niet of het een goed idee is om dat op te gaan breken / te gaan wijzigen. Dan krijg je dat het upgradebestand vol specifieke functies gaat staan. En dan wil je die eigenlijk weer in een ander bestand zetten. Dan zouden we misschien het hele upgrade systeem op de schop moeten nemen, maar als ik het zo zie vind ik dat niet nodig omdat het heel transparant is (ook al wordt het bestand dus wel lang).
There was a problem hiding this comment.
Misschien kunnen we specifieke upgrade classes maken die 1 taak regelen per upgrade. Maar soms denk ik ook dat we het ingewikkelder maken dan nodig?
Co-authored-by: Edie Lemoine <edie@myparcel.nl>
Helper/Checkout.php
Outdated
| * @param string $key | ||
| * | ||
| * @return string | ||
| */ | ||
| public function getTimeConfig($carrier, $key) | ||
| public function getTimeConfig(string $carrier, string $key):string |
There was a problem hiding this comment.
| public function getTimeConfig(string $carrier, string $key):string | |
| public function getTimeConfig(string $carrier, string $key): string |
Helper/Checkout.php
Outdated
| $timeAsString = str_replace(',', ':', $this->getCarrierConfig($key, $carrier)); | ||
| $timeComponents = explode(':', $timeAsString); | ||
| if (count($timeComponents) > 2) { | ||
| $timeAsString = $timeComponents[0] . ':' . $timeComponents[1]; |
There was a problem hiding this comment.
Voor de leesbaarheid kan je ook dit doen als je wilt:
[$hours, $minutes] = $timeComponents;
Helper/Checkout.php
Outdated
| return str_replace(',', ':', $this->getCarrierConfig($key, $carrier)); | ||
| $timeAsString = str_replace(',', ':', $this->getCarrierConfig($key, $carrier)); | ||
| $timeComponents = explode(':', $timeAsString); | ||
| if (count($timeComponents) > 2) { |
There was a problem hiding this comment.
Ik deeeenkk... dat >= 3 mentaal makkelijker te parsen is dan > 2
Helper/Checkout.php
Outdated
| { | ||
| return str_replace(',', ';', $this->getCarrierConfig($key, $carrier)); | ||
| return array_map(static function($val) { | ||
| return (is_numeric($val)) ? (int) $val : $val; |
There was a problem hiding this comment.
| return (is_numeric($val)) ? (int) $val : $val; | |
| return is_numeric($val) ? (int) $val : $val; |
* fix: do not save address in address book (#587) * fix: delivery options per carrier (#595) * feat: agecheck for products (#590) * feat: agecheck for products * feat: pps settings and exporting pps order * fix: correct tracktrace link in ordergrid (#607) * fix: use BaseConsignment where you need an instance (#609) * feat: add pickup disable option for mailbox packages (#611) * feat: add option to disable pickup for mailbox packages * feat: add insurance setting for shipments to BE (#617) * fix: strip disallowed options from consignments belgium (#622) * fix: strip disallowed options from consignments belgium * fix: getExportMode may be null on the first install * fix: label description maximum length * regression: export age check * regression: translations for dropoff delay * regression: export correct weight for dpz
No description provided.