Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix large format issue #798

Merged
merged 4 commits into from
Dec 8, 2023
Merged

fix: fix large format issue #798

merged 4 commits into from
Dec 8, 2023

Conversation

Mark-Ernst
Copy link
Contributor

@Mark-Ernst Mark-Ernst commented Dec 4, 2023

INT-236

@Mark-Ernst Mark-Ernst requested a review from a team as a code owner December 4, 2023 12:40
wthijmen
wthijmen previously approved these changes Dec 4, 2023
Copy link
Contributor

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik snap de pr niet. Je hebt getWeightTypeOfProduct gemaakt, maar die wordt niet gebruikt lijkt het?

wthijmen
wthijmen previously approved these changes Dec 5, 2023
joerivanveen
joerivanveen previously approved these changes Dec 7, 2023
wthijmen
wthijmen previously approved these changes Dec 7, 2023
@Mark-Ernst Mark-Ernst dismissed stale reviews from wthijmen and joerivanveen via 16726b5 December 8, 2023 10:23
@Mark-Ernst Mark-Ernst merged commit dd98a32 into develop Dec 8, 2023
1 check passed
@Mark-Ernst Mark-Ernst deleted the fix/fix-large-format branch December 8, 2023 10:49
MyParcelBot pushed a commit that referenced this pull request Feb 1, 2024
## [4.12.0](v4.11.1...v4.12.0) (2024-02-01)

### 🐛 Bug Fixes

* allow observer to use transport object ([#805](#805)) ([e64a687](e64a687))
* **checkout:** prevent delivery options from disappearing ([#811](#811)) ([1f153dc](1f153dc))
* **checkout:** prevent missing street from blocking delivery options ([#813](#813)) ([169e8be](169e8be))
* fix large format issue ([#798](#798)) ([dd98a32](dd98a32))
* fix php deprecation error ([#793](#793)) ([5222a77](5222a77))
* **fulfilment:** export phonenumber and weight ([#810](#810)) ([d2b2a85](d2b2a85))
* **fulfilment:** set weight on customs item rather than throw error ([#814](#814)) ([2eadcbc](2eadcbc))
* implement regression feedback ([#806](#806)) ([0b3b1f0](0b3b1f0))
* only set country if currentCountry has value ([#794](#794)) ([e86d3fe](e86d3fe))

### ✨ New Features

* add carrier dpd ([#786](#786)) ([e87fe71](e87fe71))
* add carrier ups ([#787](#787)) ([c6aff00](c6aff00))
* add digital stamp weight range ([#801](#801)) ([696b771](696b771))
* add state to consignment ([#815](#815)) ([8c3e208](8c3e208))
@MyParcelBot
Copy link

🎉 This PR is included in version 4.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants