Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkout): show carriers only for countries they ship to #273

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

EdieLemoine
Copy link
Member

No description provided.

@EdieLemoine EdieLemoine requested a review from a team as a code owner September 26, 2024 14:49
src/Hooks/HasPsCarrierListHooks.php Show resolved Hide resolved
src/Hooks/HasPsCarrierListHooks.php Outdated Show resolved Hide resolved
src/Service/PsCountryService.php Show resolved Hide resolved
src/Service/PsCountryService.php Show resolved Hide resolved
tests/factories/StateFactory.php Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Sep 27, 2024
@myparcel-bot myparcel-bot bot removed the changes requested (Auto) label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 12 lines in your changes missing coverage. Please review.

Project coverage is 48.92%. Comparing base (5c291a9) to head (5035d29).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Service/PsSpecificObjectModelService.php 0.00% 4 Missing ⚠️
src/Carrier/Service/CarrierBuilder.php 75.00% 2 Missing ⚠️
src/Hooks/HasPsCarrierListHooks.php 94.44% 2 Missing ⚠️
src/Pdk/Base/PsPdkBootstrapper.php 60.00% 2 Missing ⚠️
src/Service/PsCountryService.php 92.59% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #273      +/-   ##
============================================
- Coverage     51.96%   48.92%   -3.05%     
+ Complexity      692      584     -108     
============================================
  Files           152      150       -2     
  Lines          4191     3800     -391     
  Branches         55       55              
============================================
- Hits           2178     1859     -319     
+ Misses         1958     1886      -72     
  Partials         55       55              
Flag Coverage Δ
backend 77.23% <87.09%> (-0.81%) ⬇️
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot added the approved (Auto) label Sep 27, 2024
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Sep 27, 2024

PDK upgrade summary

The following packages were upgraded:

Package Old version New version
myparcelnl/pdk 2.42.0 2.43.4

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Sep 27, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit 5035d29
Logs https://github.com/myparcelnl/prestashop/actions/runs/11599135271
Download https://github.com/myparcelnl/prestashop/suites/30300842073/artifacts/2124648959

@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 4 times, most recently from e2fa717 to 62df26a Compare October 4, 2024 11:24
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 14 times, most recently from 82aa17d to d386d2f Compare October 11, 2024 12:45
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 2 times, most recently from 9b6060a to 0025429 Compare October 16, 2024 10:35
@EdieLemoine EdieLemoine changed the base branch from beta to main October 16, 2024 11:35
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 3 times, most recently from 81efa95 to 9960536 Compare October 23, 2024 10:16
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 4 times, most recently from 33eeb23 to 456d3fd Compare October 30, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

3 participants