fix(consignment): only validate delivery date if needed (#364)

myparcelnl · Dec 31, 2021 · fce209d · fce209d
1 parent 558e69a
commit fce209d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/Rule/Consignment/DeliveryDateRule.php b/src/Rule/Consignment/DeliveryDateRule.php
@@ -15,8 +15,9 @@ class DeliveryDateRule extends Rule
     public function validate($validationSubject): void
     {
         $isDefaultDeliveryType = AbstractConsignment::DEFAULT_DELIVERY_TYPE === $validationSubject->getDeliveryType();
+        $canHaveDeliveryDate   = $validationSubject->canHaveExtraOption(AbstractConsignment::EXTRA_OPTION_DELIVERY_DATE);
 
-        if (! $isDefaultDeliveryType && ! $validationSubject->getDeliveryDate()) {
+        if (! $isDefaultDeliveryType && $canHaveDeliveryDate && ! $validationSubject->getDeliveryDate()) {
             $this->addError(
                 sprintf(
                     'If delivery_type is not %d, delivery_date is required.',