Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.2+ support #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mikeIFTS
Copy link

@mikeIFTS mikeIFTS commented Feb 12, 2020

References #53

Minimal changes to get this package working with Django 2.2.10+

Sample CI Build is here: https://circleci.com/gh/IFTServices/django-pgviews/11?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@robvdl robvdl mentioned this pull request May 29, 2020
@@ -33,5 +33,6 @@
'Framework :: Django :: 1.9',
'Framework :: Django :: 1.10',
'Framework :: Django :: 1.11',
]
'Framework :: Django :: 2.20',
Copy link

@robvdl robvdl May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 2.2 instead of 2.20?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Framework :: Django :: 2.20',
'Framework :: Django :: 2.2',

@@ -33,5 +33,6 @@
'Framework :: Django :: 1.9',
'Framework :: Django :: 1.10',
'Framework :: Django :: 1.11',
]
'Framework :: Django :: 2.20',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Framework :: Django :: 2.20',
'Framework :: Django :: 2.2',

@@ -1 +1,2 @@
psycopg2
Django>=2.2.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Django>=2.2.2

Removing this as tests may be run under different Django versions.

@benglewis
Copy link

Any reading for the delay in the approval of this PR? I would very much like to use this code - but my codebase is already on Django 2.2 (and current Django is already Django 3.0). Can I help?

@Mogost
Copy link

Mogost commented Jun 26, 2020

@robvdl
Copy link

robvdl commented Jun 26, 2020

@benglewis the issue seems to be that there are changes requested 24 days ago, so it's upto the original author @mikeIFTS of this PR to fix these and then we should see it merged I hope.

@robvdl
Copy link

robvdl commented Jun 26, 2020

I'm not sure if a fork is the right solution, perhaps helping on the project instead?

I do get it though, Django 1.11 LTS is out of support, getting 2.2 LTS support going should be the number one priority, nothing else really matters but to get off 1.11 LTS.

@scott-w
Copy link
Contributor

scott-w commented Sep 4, 2020

Hey @robvdl normally I would agree, however as the original maintainer within Pebble, I'd give my blessing to a fork. Simply put, I don't work at Pebble any more and I don't know any of the devs that work there, so I can't influence anything from my end.

@robvdl
Copy link

robvdl commented Sep 4, 2020

Thanks @scott-w I'll have a talk with people from work on Monday. I am not currently using this but our team stumbled across it but couldn't use it due to lack of Django 2.2 support at the time so we didn't. It might be worth maintaining though, we are a company that uses Postgres a lot. I wouldn't just jump on it though, because I already maintain more than I can handle myself, know the feeling all too well.

@Mogost
Copy link

Mogost commented Sep 5, 2020

@scott-w, Maybe we should add some kind of record about the fork from @mikicz in the README file?
To make it easier for people to find a supported fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants