-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 2.2+ support #56
base: master
Are you sure you want to change the base?
Conversation
@@ -33,5 +33,6 @@ | |||
'Framework :: Django :: 1.9', | |||
'Framework :: Django :: 1.10', | |||
'Framework :: Django :: 1.11', | |||
] | |||
'Framework :: Django :: 2.20', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 2.2 instead of 2.20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Framework :: Django :: 2.20', | |
'Framework :: Django :: 2.2', |
@@ -33,5 +33,6 @@ | |||
'Framework :: Django :: 1.9', | |||
'Framework :: Django :: 1.10', | |||
'Framework :: Django :: 1.11', | |||
] | |||
'Framework :: Django :: 2.20', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Framework :: Django :: 2.20', | |
'Framework :: Django :: 2.2', |
@@ -1 +1,2 @@ | |||
psycopg2 | |||
Django>=2.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django>=2.2.2 |
Removing this as tests may be run under different Django versions.
Any reading for the delay in the approval of this PR? I would very much like to use this code - but my codebase is already on Django 2.2 (and current Django is already Django 3.0). Can I help? |
@benglewis the issue seems to be that there are changes requested 24 days ago, so it's upto the original author @mikeIFTS of this PR to fix these and then we should see it merged I hope. |
I'm not sure if a fork is the right solution, perhaps helping on the project instead? I do get it though, Django 1.11 LTS is out of support, getting 2.2 LTS support going should be the number one priority, nothing else really matters but to get off 1.11 LTS. |
Hey @robvdl normally I would agree, however as the original maintainer within Pebble, I'd give my blessing to a fork. Simply put, I don't work at Pebble any more and I don't know any of the devs that work there, so I can't influence anything from my end. |
Thanks @scott-w I'll have a talk with people from work on Monday. I am not currently using this but our team stumbled across it but couldn't use it due to lack of Django 2.2 support at the time so we didn't. It might be worth maintaining though, we are a company that uses Postgres a lot. I wouldn't just jump on it though, because I already maintain more than I can handle myself, know the feeling all too well. |
References #53
Minimal changes to get this package working with Django 2.2.10+
Sample CI Build is here: https://circleci.com/gh/IFTServices/django-pgviews/11?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link