Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypyc doesn't like some class-like NamedTuples #924

Closed
hauntsaninja opened this issue May 1, 2022 · 1 comment · Fixed by python/mypy#13078
Closed

mypyc doesn't like some class-like NamedTuples #924

hauntsaninja opened this issue May 1, 2022 · 1 comment · Fixed by python/mypy#13078

Comments

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented May 1, 2022 •
edited
Loading

For example, we get failures if we try upgrading

Also ref python/mypy#12708

Error manifests as a KeyError for the type of some field in the NamedTuple, but I also got segfaults when upgrading NamedTuples in mypyc itself
@hauntsaninja hauntsaninja mentioned this issue May 12, 2022
Closed
ichard26 added a commit to ichard26/mypy that referenced this issue Jul 6, 2022
@ichard26
[mypyc] Add LoadAddress op for PyFloat_Type & PyTuple_Type
def321d 
- Fixes mypyc/mypyc#924
- Fixes mypyc/mypyc#926

This is a follow-up of commit 7811f08.
ichard26 added a commit to ichard26/mypy that referenced this issue Jul 6, 2022
@ichard26
[mypyc] Add LoadAddress op for PyFloat_Type & PyTuple_Type
88ecffb 
- Fixes mypyc/mypyc#924
- Fixes mypyc/mypyc#926

This is a follow-up of commit 7811f08.
@ichard26 ichard26 mentioned this issue Jul 6, 2022
Merged
ichard26 added a commit to ichard26/mypy that referenced this issue Jul 6, 2022
@ichard26
[mypyc] Add LoadAddress op for PyFloat_Type & PyTuple_Type
0406c4c 
- Fixes mypyc/mypyc#924
- Fixes mypyc/mypyc#926
- Fixes mypyc/mypyc#935

This is a follow-up of commit 7811f08.
JelleZijlstra pushed a commit to python/mypy that referenced this issue Jul 12, 2022
@ichard26
[mypyc] Add LoadAddress op for PyFloat_Type & PyTuple_Type (#13078)
64a40e8 
- Fixes mypyc/mypyc#924
- Fixes mypyc/mypyc#926
- Fixes mypyc/mypyc#935

This is a follow-up of commit 7811f08.
@JelleZijlstra
Copy link
Collaborator

Fixed by python/mypy#13078

hauntsaninja pushed a commit to hauntsaninja/mypy that referenced this issue Jul 16, 2022
@ichard26 @hauntsaninja
[mypyc] Add LoadAddress op for PyFloat_Type & PyTuple_Type (python#13078
0b26ac6 
)

- Fixes mypyc/mypyc#924
- Fixes mypyc/mypyc#926
- Fixes mypyc/mypyc#935

This is a follow-up of commit 7811f08.
ilevkivskyi pushed a commit to python/mypy that referenced this issue Jul 16, 2022
@hauntsaninja @ichard26
[mypyc] Add LoadAddress op for PyFloat_Type & PyTuple_Type (#13078) (#…
88c1b85 
…13150)

- Fixes mypyc/mypyc#924
- Fixes mypyc/mypyc#926
- Fixes mypyc/mypyc#935

This is a follow-up of commit 7811f08.

Co-authored-by: Richard Si <63936253+ichard26@users.noreply.github.com>
Gobot1234 pushed a commit to Gobot1234/mypy that referenced this issue Aug 12, 2022
@ichard26 @Gobot1234
[mypyc] Add LoadAddress op for PyFloat_Type & PyTuple_Type (python#13078
6c2b5f2 
)

- Fixes mypyc/mypyc#924
- Fixes mypyc/mypyc#926
- Fixes mypyc/mypyc#935

This is a follow-up of commit 7811f08.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mypyc] Add LoadAddress op for PyFloat_Type & PyTuple_Type ichard26/mypy
2 participants
@JelleZijlstra @hauntsaninja