Skip to content

Commit

Permalink
Refine cppcheck analysis (#1133)
Browse files Browse the repository at this point in the history
- Details link on github for cppcheck now goes straight to the report
- Removed umatched suppression from the cppcheck suppression file
  • Loading branch information
fallberg authored and mfalkvidd committed May 18, 2018
1 parent ba7027c commit 4e1d69d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion .ci/static_analysis.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def cppCheck(config) {
"grep -q \"<td>0</td><td>total</td>\" cppcheck-avr_cppcheck_reports/index.html || exit_code=\$?\n"+
"exit \$((exit_code == 0 ? 0 : 1))")
if (ret == 1) {
config.pr.setBuildStatus(config, 'ERROR', 'Toll gate (Code analysis - Cppcheck)', 'Issues found', '${BUILD_URL}CppCheck_AVR/index.html')
config.pr.setBuildStatus(config, 'ERROR', 'Toll gate (Code analysis - Cppcheck)', 'Issues found', '${BUILD_URL}CppCheck_20AVR/index.html')
error 'Terminating due to Cppcheck error'
} else {
config.pr.setBuildStatus(config, 'SUCCESS', 'Toll gate (Code analysis - Cppcheck)', 'Pass', '')
Expand Down
2 changes: 0 additions & 2 deletions .mystools/cppcheck/config/suppressions.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@ ConfigurationNotChecked
unmatchedSuppression
// This suppression is because the problem is in an in-lined macro so in-line-suppressions does not appear to take effect
unreadVariable:*/MyHwNRF5.cpp
uninitMemberVar:*/TinyGsmFifo.h

0 comments on commit 4e1d69d

Please sign in to comment.