Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inclusion mode button does not work with ESP32 #1196

Closed
freynder opened this issue Aug 30, 2018 · 0 comments
Closed

Inclusion mode button does not work with ESP32 #1196

freynder opened this issue Aug 30, 2018 · 0 comments

Comments

@freynder
Copy link
Contributor

After testing the inclusion mode with an ESP32 gateway I noticed the inclusion button does not work.

The pin is in floating state instead of pulled up.
Init code:

MySensors/core/MyInclusionMode.cpp

Line 33 in 6d24ab1

hwPinMode(MY_INCLUSION_MODE_BUTTON_PIN, INPUT);

According to arduino references we should instead use INPUT_PULLUP as of Arduino 1.0.1

I will submit a PR for this.
@freynder freynder mentioned this issue Aug 30, 2018
Merged
tekka007 pushed a commit that referenced this issue Aug 30, 2018
@freynder @tekka007
Inclusion mode: change pinmode to INPUT_PULLUP (#1197)
cff3696 
Issue 1196: #1196

According to arduino references we should instead use INPUT_PULLUP
as of Arduino 1.0.1
https://www.arduino.cc/en/Tutorial/DigitalPins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@freynder