Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RadioSettingGrpPub to TransportSettingGrpPub #1272

Closed
mfalkvidd opened this issue Mar 24, 2019 · 0 comments · Fixed by #1295
Closed

Rename RadioSettingGrpPub to TransportSettingGrpPub #1272

mfalkvidd opened this issue Mar 24, 2019 · 0 comments · Fixed by #1295
Assignees

Comments

@mfalkvidd
Copy link
Member

mfalkvidd commented Mar 24, 2019

https://www.mysensors.org/apidocs/group__RadioSettingGrpPub.html has the headline "Radio selection". In MySensors lingo, we probably mean "Transport selection", especially since RS485 is included but does not use radio.

If we rename the group and the text, it might become easier for users to understand which different transports are supported by MySensors.

I am not sure why the SPI stuff is in this group though. Is there someplace else where it would fit better? If it does fit well within the transport section, could we elaborate on why?

mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue May 30, 2019
https://www.mysensors.org/apidocs/group__RadioSettingGrpPub.html
had the headline "Radio selection". In MySensors lingo, we probably
mean "Transport selection", especially since RS485 is included but
does not use radio.

By renaming the group and the text, it might become easier for users
to understand which different transports are supported by MySensors.

This fixes mysensors#1272
@mfalkvidd mfalkvidd self-assigned this May 30, 2019
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue May 30, 2019
https://www.mysensors.org/apidocs/group__RadioSettingGrpPub.html
had the headline "Radio selection". In MySensors lingo, we
probably mean "Transport selection", especially since RS485 is
included but does not use radio.

By renaming the group and the text, it might become easier for
users to understand which different transports are supported
by MySensors.

This fixes mysensors#1272
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue May 30, 2019
https://www.mysensors.org/apidocs/group__RadioSettingGrpPub.html
had the headline "Radio selection". In MySensors lingo, we
probably mean "Transport selection", especially since RS485 is
included but does not use radio.

By renaming the group and the text, it might become easier for
users to understand which different transports are supported
by MySensors.

This fixes mysensors#1272
mfalkvidd added a commit that referenced this issue May 30, 2019
https://www.mysensors.org/apidocs/group__RadioSettingGrpPub.html
had the headline "Radio selection". In MySensors lingo, we
probably mean "Transport selection", especially since RS485 is
included but does not use radio.

By renaming the group and the text, it might become easier for
users to understand which different transports are supported
by MySensors.

This fixes #1272
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Jun 3, 2019
https://www.mysensors.org/apidocs/group__RadioSettingGrpPub.html
had the headline "Radio selection". In MySensors lingo, we
probably mean "Transport selection", especially since RS485 is
included but does not use radio.

By renaming the group and the text, it might become easier for
users to understand which different transports are supported
by MySensors.

This fixes mysensors#1272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant