Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep forever by sleep(0); #1113

Merged
merged 1 commit into from
May 1, 2018
Merged

Conversation

Tombula
Copy link
Contributor

@Tombula Tombula commented Apr 19, 2018

For battery powered sensors which wake up by the RST Pin its useful to sleep the cpu forever. When using this command: sleep(INTERRUPT_NOT_DEFINED, MODE_NOT_DEFINED, 0, false);
the code will be stripped down to hwSleep(0);. But this will not sleep the cpu forever.

@mfalkvidd
Copy link
Member

mfalkvidd commented Apr 19, 2018

Looks like this problem was introduced intentionally by #814

@mfalkvidd
Copy link
Member

@Tombula would you mind amending the commit message to make Gitler happy? Just run git commit --amend and manually add newlines to the commit message. Then force push your branch.

@Tombula
Copy link
Contributor Author

Tombula commented Apr 21, 2018

@mfalkvidd I'm very new to git and it's commit system. I just did the commit using the website github.com. But I think you want me to clone the Repository on my system, change the specific file and than execute git commit --amend?
Thank you very much for your time :)

@mfalkvidd
Copy link
Member

@Tombula Partly. You can clone your own fork, which already has the file change.
Something like this:

git clone YOUR-GITHUB-EMAIL-ADDRESS:Tombula/MySensors.git --branch patch-1
git commit --amend
(edit the commit message)
git push -f

@Tombula Tombula force-pushed the patch-1 branch 2 times, most recently from 3c6f5e1 to a2a9fa8 Compare April 22, 2018 11:47
For battery powered sensors which wake up by the RST Pin its useful
to sleep the cpu forever. When using this command:
sleep(INTERRUPT_NOT_DEFINED, MODE_NOT_DEFINED, 0, false);
the code will be stripped down to hwSleep(0);.
But this will not sleep the cpu forever.
@mfalkvidd mfalkvidd merged commit 1c5853c into mysensors:development May 1, 2018
fallberg pushed a commit that referenced this pull request Jun 18, 2018
For battery powered sensors which wake up by the RST Pin its useful
to sleep the cpu forever. When using this command:
sleep(INTERRUPT_NOT_DEFINED, MODE_NOT_DEFINED, 0, false);
the code will be stripped down to hwSleep(0);.
But this will not sleep the cpu forever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants