Allow splash screen to redirect to MY_DEBUGDEVICE if defined (#1057) #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekka007
requested changes
Oct 21, 2018
core/MySplashScreen.cpp
Outdated
| @@ -19,6 +19,10 @@ | |||
|
|
|||
| #include "MySensorsCore.h" | |||
|
|
|||
| #ifndef MY_DEBUGDEVICE | |||
| #define MY_DEBUGDEVICE MY_SERIALDEVICE | |||
There was a problem hiding this comment.
Not needed, definition set in arch headers (MyHw****.h)
There was a problem hiding this comment.
I have pushed the corrections.
tekka007
approved these changes
Oct 22, 2018
tekka007
added a commit
that referenced
this pull request
Oct 23, 2018
This was referenced Oct 23, 2018
Merged
tekka007
added a commit
to tekka007/MySensors
that referenced
this pull request
Oct 23, 2018
This reverts commit f5676a3.
tekka007
added a commit
that referenced
this pull request
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1057