Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document esp8266 limitation for MY_RX_MESSAGE_BUFFER_FEATURE #1296

Merged
merged 1 commit into from
May 30, 2019
Merged

Document esp8266 limitation for MY_RX_MESSAGE_BUFFER_FEATURE #1296

merged 1 commit into from
May 30, 2019

Conversation

mfalkvidd
Copy link
Member

This fixes
#1128

@mfalkvidd mfalkvidd requested a review from Yveaux May 30, 2019 17:01
@mfalkvidd
Copy link
Member Author

For updated documentation see https://ci.mysensors.org/job/MySensors/job/MySensors/job/PR-1296/1/Doxygen_20HTML/group__RF24SettingGrpPub.html

@tekka007 tekka007 merged commit cdfd8d7 into mysensors:development May 30, 2019
@Yveaux
Copy link
Member

Yveaux commented May 31, 2019

My conclusion in #1128 was:

Summing up

  • AVR, SAMD and probably Linux work out of the box.
  • STM32, nRF52, ESP8266 and SoftSPI need explicit protection in the MySensors stack until complete SPI transactions are implemented correctly.

So adding only a remark for ESP8266 is not enough.
Furthermore my comment is dated August 1, 2018, so things might have changed since.

@mfalkvidd mfalkvidd mentioned this pull request Jun 3, 2019
Closed
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this pull request Jun 3, 2019
@mfalkvidd
Document esp8266 limitation for MY_RX_MESSAGE_BUFFER_FEATURE (mysenso…
cbce95d 
…rs#1296)

This fixes
mysensors#1128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yveaux Yveaux Awaiting requested review from Yveaux

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfalkvidd @Yveaux @tekka007