Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MyMessage.cpp #1352

Merged
merged 2 commits into from
Oct 13, 2019
Merged

Update MyMessage.cpp #1352

merged 2 commits into from
Oct 13, 2019

Conversation

rikki78
Copy link
Contributor

@rikki78 rikki78 commented Oct 8, 2019

Fixes #1349

@tekka007
Copy link
Contributor

tekka007 commented Oct 9, 2019

Hi Rik, thanks for your contribution!
In order to pass our CI checks, you have to integrate #1351 into #1352 and resubmit this PR. Please also sign the CLA.

@rikki78
Copy link
Contributor Author

rikki78 commented Oct 9, 2019

All right. I think it should be okay now.

@rikki78
Copy link
Contributor Author

rikki78 commented Oct 9, 2019

I have to say I had issues after this update of the gateway. I suspect it is because not all nodes and repeaters were updated. So I have the previous commit in a repeater, this didn't work anymore last night.
Can you estimate if this is somehow explainable?

@tekka007 tekka007 self-assigned this Oct 9, 2019
@tekka007 tekka007 added the bug label Oct 9, 2019
@rikki78
Copy link
Contributor Author

rikki78 commented Oct 13, 2019

Is the PR now okay? I deleted the wrong branch I think when merging the two together, and now it points to an unknown repository. Let me know if I have to do it again.

@tekka007 tekka007 merged commit 4947a63 into mysensors:development Oct 13, 2019
@tekka007
Copy link
Contributor

Looks good, merging ok. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not receiving echo anymore
2 participants