Header Tweaks #14
Merged
Header Tweaks #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mysilio/garden/67uHyr8n9a3SvWVag9qstQqPdyXN |
travis
requested changes
Oct 6, 2021
components/Avatar.jsx
Outdated
| export default function Avatar({ src, className }) { |
There was a problem hiding this comment.
need to pass ..rest through to the top level element the way we do on lines 1 and 3 in the removed stuff above
There was a problem hiding this comment.
Gotcha, missed that in the rebase. Whoa you can just splat those out in the component call, that's cool
ianconsolata
commented
Oct 6, 2021
| /> | ||
| ); | ||
| } else { | ||
| return ( | ||
| <span | ||
| className={`inline-block h-12 w-12 rounded-full overflow-hidden bg-gray-100 cursor-pointer ${className}`} | ||
| {...rest} |
There was a problem hiding this comment.
@travis Do I want this one too? If so did I put it in the right place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of small changes I had on my branch that are still relevant after your modal work.