Apply suggestions from code review

Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
myskov · Jan 2, 2024 · 0086789 · 0086789
1 parent 3e4dfa9
commit 0086789
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/.../s3gateway/src/main/java/org/apache/hadoop/ozone/s3secret/S3SecretManagementEndpoint.java b/.../s3gateway/src/main/java/org/apache/hadoop/ozone/s3secret/S3SecretManagementEndpoint.java
@@ -63,16 +63,16 @@ private Response generateInternal(@Nullable String username) throws IOException
       S3SecretResponse s3SecretResponse = new S3SecretResponse();
       s3SecretResponse.setAwsSecret(s3SecretValue.getAwsSecret());
       s3SecretResponse.setAwsAccessKey(s3SecretValue.getAwsAccessKey());
-      AUDIT.logReadSuccess(buildAuditMessageForSuccess(
+      AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
           S3GAction.GENERATE_SECRET, getAuditParameters()));
       return Response.ok(s3SecretResponse).build();
     } catch (OMException e) {
       AUDIT.logWriteFailure(buildAuditMessageForFailure(
-          S3GAction.REVOKE_SECRET, getAuditParameters(), e));
+          S3GAction.GENERATE_SECRET, getAuditParameters(), e));
       if (e.getResult() == OMException.ResultCodes.S3_SECRET_ALREADY_EXISTS) {
         return Response.status(BAD_REQUEST.getStatusCode(), e.getResult().toString()).build();
       } else {
-        LOG.error("Can't execute revoke secret request: ", e);
+        LOG.error("Can't execute get secret request: ", e);
         return Response.serverError().build();
       }
     }