Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an admin page for bodies with missing email #6424

Closed
garethrees opened this issue Aug 4, 2021 · 4 comments
Closed

Add an admin page for bodies with missing email #6424

garethrees opened this issue Aug 4, 2021 · 4 comments
Labels
enhancement Adds new functionality f:admin x:uk

Comments

@garethrees
Copy link
Member

Extracted a specific item from #6423.

We currently show 178 > Find missing FOI email for these public authorities (try phoning!), but the list is limited to 20 bodies.

What do do

We should add something like /admin/bodies/without_request_email that renders a paginated list of bodies without a request_email.

We already have a model scope (PublicBody.without_request_email) so this is just a case of creating the controller and view. We should be able to generalise/reuse most of the view from the normal authorities list.

Getting there

Doesn't feel like this warrants a main admin nav item.

This can be linked from the bottom of the summary list

Screenshot 2021-08-04 at 09 14 45

And from the btn-toolbar on the main bodies list.

Screenshot 2021-08-04 at 09 13 11

@RichardTaylor
Copy link

Also I'd get rid of the "(try phoning!)" ... that's certainly not part of the process at WhatDoTheyKnow.com - we try to keep records in writing of everything we do, and why - it's surprising how often that comes in useful.

mysociety-pusher pushed a commit that referenced this issue Aug 4, 2021
We prefer written communication at WhatDoTheyKnow so this isn't
appropriate. How to get an authority address is a question of site
policy, so that should be documented elsewhere, since it'll vary from
country to country.

Resolves the comment #6424 (comment)
@garethrees
Copy link
Member Author

On reflection I'd demote this in favour of #3477.

@garethrees
Copy link
Member Author

On reflection I'd demote this in favour of #3477.

Looking at this again today, maybe not. This is likely to be significantly easier to implement and would at least give us a better workflow for handling this ourselves with more structured volunteering tasks.

@garethrees
Copy link
Member Author

This now exists via /admin/tags/missing_email #7250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds new functionality f:admin x:uk
Projects
None yet
Development

No branches or pull requests

2 participants