[#5080] Use browser locale #5354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for trying to conditionally check the user's language preference from their browser settings first before accepting the locale from params as that is never nil when the default locale is not included in the URL (which is true for most of our sites)
This might not work as expected from an incognito session. More testing needed!
Otherwise if the session resets, the data is lost. Also we check cookies but I can't see where we set it.
Otherwise the data in @locales can get out of sync and the language switcher can be rendered incorrectly
Really confusing otherwise as we always think of the locale from params as the authortative setting
houndci-bot
reviewed
Aug 21, 2019
| browser_locale = | ||
| if AlaveteliConfiguration.use_default_browser_language | ||
| request.env['HTTP_ACCEPT_LANGUAGE'] | ||
| else |
|
Closed to reduce overwhelm of high WIP. Can reopen in the future if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
#5080
What does this do?
A quick spike exploring what might be involved in accepting the user's language preferences from their browser settings (only relevant to multi language sites)
Why was this needed?
We currently give more weight than intended to the default locale when falling back to it without a param value (when the site is configured not to have the default locale in the URL - which is the most common choice).
Implementation notes
(In other words, I may have justified nobody working on this as it's more trouble than it's worth!)
Notes to reviewer
The unexpected finding on
collect_locales(155799e) might be useful though - although maybe it could go inAlaveteliLocalization.set_locales? - if there is ever a reported problem with the language switcher working incorrectly after a locale change.