[#5516] Account for new MaxMind license restrictions #5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 2, 2020
| @@ -73,6 +73,7 @@ module AlaveteliConfiguration | |||
| :ISO_COUNTRY_CODE => 'GB', | |||
| :ISO_CURRENCY_CODE => 'GBP', | |||
| :MINIMUM_REQUESTS_FOR_STATISTICS => 100, | |||
| :MAXMIND_LICENSE_KEY => '', | |||
There was a problem hiding this comment.
Ignoring for now to make this commit easier to cherry-pick to older releases.
gbp
reviewed
Jan 3, 2020
gbp
approved these changes
Jan 6, 2020
As of December 30 2019 GeoLite2 databases are no longer served from a public URL [1]. Downloads now require a license key, obtained through a free maxmind.com account. * Add MAXMIND_LICENSE_KEY config. Allows us to supply a `license_key` parameter to the new direct download URL [2]. * Update `geoip:download_data` task to use the new authenticated URL. Fixes #5516 [1] https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/ [2] https://dev.maxmind.com/geoip/geoipupdate/#Direct_Downloads
mysociety-pusher
force-pushed
the
5516-maxmind-license-key
branch
from
f44c220 to
2d6672c
Compare
This was referenced Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #5516
What does this do?
license_keyparameter to the new direct download URL [2].
geoip:download_datatask to use the new authenticated URL.Why was this needed?
As of December 30 2019 GeoLite2 databases are no longer served from a
public URL [1]. Downloads now require a license key, obtained through a
free maxmind.com account.
Implementation notes
Screenshots
Notes to reviewer
rm vendor/data/*)MAXMIND_LICENSE_KEYrake geoip:download_dataCan also see records of download in MaxMind account download history:
[1] https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/
[2] https://dev.maxmind.com/geoip/geoipupdate/#Direct_Downloads