[#6008] Use Uglifier's experimental Harmony mode for ES6 #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superseded by #6010 |
|
Looks like we might need this after all as ES6 syntax is also used in clipboard.js introduced in 366d87c |
4d2ab5a introduces ES6 syntax, which Uglifier doesn't support by default [1]. This commit enables the experimental "Harmony mode", along with disabling `mangle` and `compress` as per the usage recommendations [2]. This doesn't seem like a good long-term solution, since development of Harmony mode has stopped and may be removed. This at least allows us to deploy 4d2ab5a for now. Fixes #6008. [1] https://github.com/lautis/uglifier#es6--es2015--harmony-mode [2] https://github.com/lautis/uglifier#usage [3] lautis/uglifier#142 (comment)
gbp
force-pushed
the
enable-uglifier-harmony-mode
branch
from
dd0836c to
38cb5ec
Compare
gbp
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
uglifier HEAD has dropped the harmony option and are recommending https://github.com/ahorek/terser-ruby as a better option.
I've tested both and exactly the same JS is outputted.
For now lets stick with uglifier until:
- the next version is relaesed and switch to terser then
- we migrate to webpacker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4d2ab5a introduces ES6 syntax, which Uglifier doesn't support by
default [1].
This commit enables the experimental "Harmony mode", along with
disabling
mangleandcompressas per the usage recommendations [2].This doesn't seem like a good long-term solution, since development of
Harmony mode has stopped and may be removed. This at least allows us to
deploy 4d2ab5a for now.
Fixes #6008.
[1] https://github.com/lautis/uglifier#es6--es2015--harmony-mode
[2] https://github.com/lautis/uglifier#usage
[3] lautis/uglifier#142 (comment)