[#285] Add Friendly ID gem #7735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2023
garethrees
reviewed
May 10, 2023
Used to store `User#url_name` slugs in a separate model retaining history and the ability to load users using old slugs. Configuration is in an `User::Slug` module instead of the initializer as we could potentially use this for other models which store slugs. EG `InfoRequest` or `PublicBody`.
Needs to override some internal friendly_id methods to use the non-history module version. These methods relate to the generation and searching for slugs as this will currently fail due to history module expecting this information to be in `FriendlyID::Slug` instances but until we migrate the existing records to this model is doesn't exist. We will add a `temporary` rake task to migrate slugs.
Current `url_name` need to be stored as slugs in order to correctly generate slugs and find User instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Requires #7702
Connected to #285
What does this do?
friendly_idgemUser#url_namegenerationFriendlyID::Slugmodel.Why was this needed?
To allow user to change their names without breaking URLs. The
friendly_idgem will store old slugs and correctly load the record if the old URL is hit.Implementation notes
Unfortunately we need to override some of
friendly_idinternal methods until we do the next release.